Skip to content

fix: use WidgetSelectDropdown for models #6607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2025
Merged

fix: use WidgetSelectDropdown for models #6607

merged 2 commits into from
Nov 6, 2025

Conversation

@arjansingh
Copy link
Contributor

@arjansingh arjansingh commented Nov 6, 2025 •
edited
Loading

Summary

As the commit says, the model loaders were broken in cloud if you enabled Vue Nodes (not a thing I think user does yet).

This fixes it by configuring the WidgetSelectDropdown to load so the user load models like they would load a input or output asset.

Review Focus

Probably useAssetWidgetData to make sure it's idomatic.

This part of assetsStore as well.

Screenshots

Screenshot 2025-11-05 at 5 34 22 PM

┆Issue is synchronized with this Notion page by Unito

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Nov 6, 2025
@github-actions
Copy link

github-actions bot commented Nov 6, 2025 •
edited
Loading

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 11/06/2025, 03:36:16 AM UTC

📈 Summary

  • Total Tests: 501
  • Passed: 470 ✅
  • Failed: 0
  • Flaky: 1 ⚠️
  • Skipped: 30 ⏭️

📊 Test Reports by Browser

  • ✅ chromium: View Report • ✅ 461 / ❌ 0 / ⚠️ 1 / ⏭️ 30
  • ✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Nov 6, 2025 •
edited
Loading

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 11/06/2025, 03:22:24 AM UTC

🔗 Links

🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Nov 6, 2025 •
edited
Loading

Bundle Size Report

Summary

  • Raw size: 12.2 MB baseline 12.2 MB — 🔴 +2.98 kB
  • Gzip: 2.49 MB baseline 2.49 MB — 🔴 +652 B
  • Brotli: 1.96 MB baseline 1.96 MB — 🔴 +448 B
  • Bundles: 58 current • 58 baseline • 17 added / 17 removed

Category Glance
App Entry Points 🔴 +2.96 kB (3.25 MB) · Vendor & Third-Party 🔴 +22 B (5.32 MB) · Other ⚪ 0 B (2.55 MB) · Graph Workspace ⚪ 0 B (792 kB) · Panels & Settings ⚪ 0 B (293 kB) · UI Components ⚪ 0 B (12.6 kB) · + 3 more

Per-category breakdown
App Entry Points — 3.25 MB (baseline 3.25 MB) • 🔴 +2.96 kB

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-Dx-76AmQ.js (new) — 2.87 MB 🔴 +2.87 MB 🔴 +594 kB 🔴 +449 kB
assets/index-OxW43xJN.js (removed) 2.86 MB — 🟢 -2.86 MB 🟢 -593 kB 🟢 -449 kB
assets/index-CHECDNaL.js (removed) 382 kB — 🟢 -382 kB 🟢 -76.6 kB 🟢 -62 kB
assets/index-DPzw8FEr.js (new) — 382 kB 🔴 +382 kB 🔴 +76.6 kB 🔴 +62.1 kB
assets/index-CLW3cQb1.js (removed) 1.75 kB — 🟢 -1.75 kB 🟢 -578 B 🟢 -487 B
assets/index-Cs1ztVN4.js (new) — 1.75 kB 🔴 +1.75 kB 🔴 +575 B 🔴 +482 B

Status: 3 added / 3 removed

Graph Workspace — 792 kB (baseline 792 kB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-CaTGpg4E.js (removed) 792 kB — 🟢 -792 kB 🟢 -155 kB 🟢 -119 kB
assets/GraphView-CzHMmMRe.js (new) — 792 kB 🔴 +792 kB 🔴 +155 kB 🔴 +119 kB

Status: 1 added / 1 removed

Views & Navigation — 8.18 kB (baseline 8.18 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/UserSelectView-BNxvMmsj.js (new) — 8.18 kB 🔴 +8.18 kB 🔴 +2.48 kB 🔴 +2.17 kB
assets/UserSelectView-BQtwDkAG.js (removed) 8.18 kB — 🟢 -8.18 kB 🟢 -2.48 kB 🟢 -2.18 kB

Status: 1 added / 1 removed

Panels & Settings — 293 kB (baseline 293 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CreditsPanel-CKLkbgXZ.js (removed) 23 kB — 🟢 -23 kB 🟢 -5.48 kB 🟢 -4.79 kB
assets/CreditsPanel-nq5cJypa.js (new) — 23 kB 🔴 +23 kB 🔴 +5.48 kB 🔴 +4.8 kB
assets/KeybindingPanel-CZHQ8-HJ.js (removed) 15.3 kB — 🟢 -15.3 kB 🟢 -3.78 kB 🟢 -3.33 kB
assets/KeybindingPanel-DDeixymh.js (new) — 15.3 kB 🔴 +15.3 kB 🔴 +3.78 kB 🔴 +3.32 kB
assets/ExtensionPanel-BzVe6YHk.js (new) — 12.1 kB 🔴 +12.1 kB 🔴 +2.84 kB 🔴 +2.5 kB
assets/ExtensionPanel-DqMuKlm-.js (removed) 12.1 kB — 🟢 -12.1 kB 🟢 -2.84 kB 🟢 -2.49 kB
assets/AboutPanel-B0J1PRuO.js (removed) 10.3 kB — 🟢 -10.3 kB 🟢 -2.67 kB 🟢 -2.34 kB
assets/AboutPanel-BiPK70nA.js (new) — 10.3 kB 🔴 +10.3 kB 🔴 +2.67 kB 🔴 +2.34 kB
assets/ServerConfigPanel-Bc42bgQ1.js (removed) 8.23 kB — 🟢 -8.23 kB 🟢 -2.17 kB 🟢 -1.91 kB
assets/ServerConfigPanel-Dbxp6kD8.js (new) — 8.23 kB 🔴 +8.23 kB 🔴 +2.17 kB 🔴 +1.92 kB
assets/UserPanel-78E--Nai.js (new) — 7.94 kB 🔴 +7.94 kB 🔴 +2.07 kB 🔴 +1.81 kB
assets/UserPanel-CoVVxp2G.js (removed) 7.94 kB — 🟢 -7.94 kB 🟢 -2.07 kB 🟢 -1.81 kB
assets/settings-0O6mq5to.js 24.3 kB 24.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-BYaBy7dC.js 20.4 kB 20.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-C3vygQN4.js 25.7 kB 25.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CbKYXyH0.js 22.7 kB 22.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CCholIsI.js 25 kB 25 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DFX7vRkK.js 19.8 kB 19.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-INJLrcmT.js 31.3 kB 31.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-iR6BKRXe.js 23.7 kB 23.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-YjQmudNE.js 23.5 kB 23.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 6 added / 6 removed

UI Components — 12.6 kB (baseline 12.6 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyQueueButton-CXveAGN4.js (removed) 11.3 kB — 🟢 -11.3 kB 🟢 -2.83 kB 🟢 -2.5 kB
assets/ComfyQueueButton-D9sObVTx.js (new) — 11.3 kB 🔴 +11.3 kB 🔴 +2.83 kB 🔴 +2.49 kB
assets/UserAvatar.vue_vue_type_script_setup_true_lang-D2s8tnS2.js 1.26 kB 1.26 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 1 added / 1 removed

Data & Services — 10.4 kB (baseline 10.4 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/keybindingService-CdzfGB4n.js (new) — 7.6 kB 🔴 +7.6 kB 🔴 +1.85 kB 🔴 +1.6 kB
assets/keybindingService-qwMCstTI.js (removed) 7.6 kB — 🟢 -7.6 kB 🟢 -1.84 kB 🟢 -1.59 kB
assets/serverConfigStore-BOo8M-7s.js (new) — 2.79 kB 🔴 +2.79 kB 🔴 +889 B 🔴 +773 B
assets/serverConfigStore-C6-plV2F.js (removed) 2.79 kB — 🟢 -2.79 kB 🟢 -891 B 🟢 -781 B

Status: 2 added / 2 removed

Utilities & Hooks — 1.07 kB (baseline 1.07 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/mathUtil-CTARWQ-l.js 1.07 kB 1.07 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
Vendor & Third-Party — 5.32 MB (baseline 5.32 MB) • 🔴 +22 B

External libraries and shared vendor chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/vendor-other-Bfb5Ofrh.js (new) — 3.22 MB 🔴 +3.22 MB 🔴 +685 kB 🔴 +549 kB
assets/vendor-other-CI2CU2ff.js (removed) 3.22 MB — 🟢 -3.22 MB 🟢 -685 kB 🟢 -549 kB
assets/vendor-tiptap-BgnRckdA.js (removed) 232 kB — 🟢 -232 kB 🟢 -45.7 kB 🟢 -37.7 kB
assets/vendor-tiptap-Dvg9y4X0.js (new) — 232 kB 🔴 +232 kB 🔴 +45.7 kB 🔴 +37.7 kB
assets/vendor-vue-C1cscJ7w.js (removed) 92.6 kB — 🟢 -92.6 kB 🟢 -23.9 kB 🟢 -20.8 kB
assets/vendor-vue-SdQKVoRx.js (new) — 92.6 kB 🔴 +92.6 kB 🔴 +23.9 kB 🔴 +20.8 kB
assets/vendor-primevue-PESgPnbc.js 517 B 517 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-three-JDoAqkQm.js 1.37 MB 1.37 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-xterm-BZLod3g9.js 407 kB 407 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 3 added / 3 removed

Other — 2.55 MB (baseline 2.55 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/commands-B2KZRBmX.js 15.1 kB 15.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-Bw-ckyga.js 13.9 kB 13.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-C_NmM85I.js 13.8 kB 13.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CuozCW4W.js 14 kB 14 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DGfVUJCR.js 16.2 kB 16.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-dOJNDogK.js 14.5 kB 14.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DwiE551e.js 14.7 kB 14.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-Fw7mvqSy.js 13.1 kB 13.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-FXnO1W4Q.js 13.2 kB 13.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-B28vuueQ.js 58.7 kB 58.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-B5DMAz5p.js 76.3 kB 76.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-B9oeRB3u.js 66.2 kB 66.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-BfxLm2q9.js 68.4 kB 68.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Bqw7zi8p.js 92.9 kB 92.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-CxXcIMmb.js 80.3 kB 80.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-DbrkzQIr.js 70.6 kB 70.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-DwpdJL5U.js 67.5 kB 67.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-mC3TQk_1.js 59.4 kB 59.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-3I1vPgv4.js 181 kB 181 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-B2huPGKQ.js 190 kB 190 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-BWugyUzd.js 215 kB 215 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-bXqu6Stq.js 194 kB 194 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CtB2M3sY.js 229 kB 229 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-D-rCrn-T.js 200 kB 200 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-D38DSnl1.js 179 kB 179 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-DAsU52ON.js 192 kB 192 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-DnGONaA_.js 196 kB 196 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Prettier formatting

@arjansingh arjansingh force-pushed the feat/vue-node-checkpoint-nodes branch 2 times, most recently from b6b9bc2 to 5ee5630 Compare November 6, 2025 01:56
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Prettier formatting

arjansingh and others added 2 commits November 5, 2025 19:20
@arjansingh
fix: use WidgetSelectDropdown for models
e1e9ca3 
VueNodes only for cloud distribution. Nothing was show on cloud for this
previously.
@actions-user @arjansingh
[automated] Apply ESLint and Prettier fixes
6363735
@arjansingh arjansingh force-pushed the feat/vue-node-checkpoint-nodes branch from 24a2c6d to 6363735 Compare November 6, 2025 03:20
@arjansingh arjansingh enabled auto-merge (squash) November 6, 2025 03:22
@arjansingh arjansingh merged commit 8849d54 into main Nov 6, 2025
26 checks passed
@arjansingh arjansingh deleted the feat/vue-node-checkpoint-nodes branch November 6, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrJKL DrJKL DrJKL approved these changes

Assignees

No one assigned

Labels

size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arjansingh @DrJKL @actions-user