Skip to content

Conversation

adamschoenemann
Copy link
Contributor

I ran into an issue after upgrading to capacitor 5: I could not build my project anymore, because the tests from this project (which I depend on) would not compile. A recent upgrade to androidx moved some stuff around. Furthermore, the error is in a test stub, which I of course, as a consumer, do not need.

This PR:

  • fixes the test stub so it compiles
  • excludes the android tests from the npm package
  • Note: I did not exclude the iOS tests, as I do not have a Mac at hand, so I cannot verify it could cause issues to exclude the tests

@reslear
Copy link
Collaborator

reslear commented Oct 8, 2023

could you check?

@adamschoenemann
Copy link
Contributor Author

Hi @reslear, I'm not sure what you want me to check? Is it the iOS tests? I don't have mac at hand, unfortunately

@reslear
Copy link
Collaborator

reslear commented Oct 9, 2023

Hi @reslear, I'm not sure what you want me to check? Is it the iOS tests? I don't have mac at hand, unfortunately

no, test your changes like locally or npm patch

@adamschoenemann
Copy link
Contributor Author

Aha, this I already did. I used npm i [email protected]:adamschoenemann/CapacitorGoogleAuth#capacitor-5-tests and then went through the motions; I could see that the tests were no longer included and that my downstream project could now compile.

@reslear reslear merged commit 113efbe into CodetrixStudio:master Oct 9, 2023
@adamschoenemann
Copy link
Contributor Author

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants