fix: use the add label API rather than patching the entire issue #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lisenish
approved these changes
Oct 31, 2024
Contributor
Author
|
@caugner do you think we can merge this PR? |
Contributor
Author
|
Thanks @johnlk , can you please merge as well 🙇🏼 |
Contributor
Weird, seems there's a PR check that's blocking. Maybe we need to update the branch protection rules or run something. @JavierCane can you support here? |
Contributor
|
@rgomezcasas can you check this one? It seems a small but powerful fix |
JavierCane
approved these changes
May 25, 2025
Member
|
Merging and releasing a new version as a bugfix. Sorry for not replying sooner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
When adding a Label to the PR, we should use the Add Label API rather than the API to update the entire issue.
The current implementation can lead to unexpected behaviour if another labelling job is running in parallel, e.g., it can remove the label added by another job if timings match.
Notes to Reviewer
How to test
Link to issues addressed