Skip to content

Conversation

@lionseal
Copy link
Contributor

Hello!

I added -w option to grep so it matches the whole label name.

We have other labels in our repos and it's matching the first character, ie:

  • Our size labels are: XS,S,M,L,XL
  • Other labels we have start with S,M,L, as in Simulation, Microservice, etc

When grep runs it matches Simulation, thus later removing it from the PR (which we don't want!)

@johnlk
Copy link
Contributor

johnlk commented Apr 16, 2024

Interesting, not sure why there's not a full word match from the beginning. I suppose if the labels are "size/xs" as the defaults of this project are, then a partial match is usually fine because it's unlikely to conflict with other labels.

Copy link
Contributor

@johnlk johnlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for spotting

@johnlk johnlk merged commit 891ac86 into CodelyTV:main Apr 16, 2024
@lionseal lionseal deleted the patch-1 branch April 17, 2024 14:55
@lionseal
Copy link
Contributor Author

Thanks for reviewing! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants