Support size label customization #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: #25
Member
|
Thx for the contribution! Please, give us some time to review it. However, in order to provide quick feedback, the feature totally makes sense, so you can assume that it will be merged 😊 |
|
I am looking to add an action for labeling the size of the PR. I see there are a few options on the marketplace. Seeing this PR is about to be merged makes my decision to use this tool. Looking forward to it! |
Prevents issues with $10 and higher.
Contributor
Author
|
Pushed up fix for positional arguments to use curly braces, since anything above $9 can incorrectly expand (e.g. |
rgomezcasas
approved these changes
Sep 20, 2021
Member
rgomezcasas
left a comment
rgomezcasas
left a comment
There was a problem hiding this comment.
Thanks a lot and sorry for the delay reviewing it!! 👌👏
Member
|
Released in |
bflad
added a commit
to hashicorp/terraform-provider-external
that referenced
this pull request
Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26 The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad
added a commit
to hashicorp/terraform-provider-http
that referenced
this pull request
Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26 The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad
added a commit
to hashicorp/terraform-provider-local
that referenced
this pull request
Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26 The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad
added a commit
to hashicorp/terraform-provider-null
that referenced
this pull request
Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26 The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad
added a commit
to hashicorp/terraform-provider-random
that referenced
this pull request
Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26 The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad
added a commit
to hashicorp/terraform-provider-tls
that referenced
this pull request
Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26 The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad
added a commit
to hashicorp/terraform-provider-external
that referenced
this pull request
Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26 The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad
added a commit
to hashicorp/terraform-provider-http
that referenced
this pull request
Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26 The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad
added a commit
to hashicorp/terraform-provider-local
that referenced
this pull request
Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26 The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad
added a commit
to hashicorp/terraform-provider-null
that referenced
this pull request
Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26 The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad
added a commit
to hashicorp/terraform-provider-random
that referenced
this pull request
Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26 The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad
added a commit
to hashicorp/terraform-provider-tls
that referenced
this pull request
Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26 The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25