Skip to content

Null Safety Migration #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 15, 2021
Merged

Null Safety Migration #45

merged 7 commits into from
Mar 15, 2021

Conversation

rayliverified
Copy link
Contributor

No description provided.

@rayliverified
Null Safety Migration #1
e413583 
*Run dart migrate.
*Resolve warnings.
*Manually migrate responsive_wrapper.dart.
@rayliverified
Null Safety Migration #2
927af38 
*Make ResponsiveWrapperData values nonnull.
@rayliverified rayliverified mentioned this pull request Mar 4, 2021
Closed
@eroo36
Copy link

eroo36 commented Mar 7, 2021

hello so i still didnt really understand the concept of the null safety or how to apply it and not even expert enough to make my own packages yet so i tried to check it but probably what i will tell here might not really help. I tested two web projects using nullsafety branch and didnt see any problem or error. Only things that i saw on the console are some warnings like:
"The operand can't be null, so the condition is always true. Remove the condition.dart(unnecessary_null_comparison) responsive_grid.dart line 61"
So these are only warnings so i guess they are not that important. Anyways i dont know how can i help here if you have suggestions how i can help let me know.

brenodt
brenodt reviewed Mar 8, 2021
View reviewed changes
Copy link

@brenodt brenodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found these points that I was unsure about. Besides that, PR looks good to me.

@rayliverified
Copy link
Contributor Author

Thank you for reviewing @brenodt .
I'll make the changes next week and also migrate the sample projects.
There's also some new development this week using the ResponsiveFramework to give me greater confidence that the null safety migration works as expected.

@rayliverified
Null Safety Migration #3
3bf8a8b 
*Migrate scroll behavior.
@rayliverified
Null Safety Migration #4 Part 1
9dd4cb7 
*Remove unnecessary asserts.
@rayliverified
Null Safety Migration #3 Part 2
1e8863d 
*Migrate clamping scroll behavior.
@rayliverified
Responsive Grid Update #2
09361a9 
*Add clip behavior and restoration ID properties.
@rayliverified
Update Example
931556d
@rayliverified
Copy link
Contributor Author

@eroo36 Thank you for testing and catching the asserts.

@rayliverified rayliverified merged commit ec4279e into master Mar 15, 2021
@rayliverified rayliverified deleted the nullsafety branch March 15, 2021 02:32
@rainteen rainteen mentioned this pull request Jun 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@brenodt brenodt brenodt left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rayliverified @eroo36 @brenodt