AOT support for Games Client #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced traditional .sln files with simplified .slnx files for all solutions, including: - Codebreaker.Analyzers - Codebreaker.Backend.Cosmos - Codebreaker.Backend.Models - Codebreaker.Backend.Postgres - Codebreaker.Backend.SqlServer - Codebreaker.GameAPIs.Client The .slnx format provides a cleaner, XML-based structure with `<Solution>` and `<Project>` elements, omitting detailed configuration and platform settings. This change improves simplicity, maintainability, and compatibility with modern tooling.
Added `<IsAotCompatible>true</IsAotCompatible>` to the project file for AOT compatibility. Updated `Microsoft.Extensions.Logging.Abstractions` to version `9.0.9` for `net9.0`. Replaced static `JsonSerializerOptions` with a source-generated `GamesClientJsonContext` for JSON serialization in `GamesClient.cs`. Refactored all HTTP client methods to use `GamesClientJsonContext` for improved performance and maintainability. Introduced a new partial class `GamesClientJsonContext` with `[JsonSourceGenerationOptions]` and `[JsonSerializable]` attributes to define serializable types. These changes enhance performance, reduce runtime overhead, and improve compatibility with AOT scenarios.
Simplified `GameType` enum in `CreateGameRequest.cs` by removing conditional compilation and redundant `JsonConverter` attributes. Compatibility with .NET 7 is no longer required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Classification
Code cleanup and modernization to align with .NET best practices.
PR Summary
This PR replaces outdated
.slnfiles with.slnxfiles, introduces source-generated JSON serialization, and updates project compatibility and dependencies..slnfiles with.slnxfiles for a cleaner, XML-based solution format.GamesClient.cs: Refactored to useGamesClientJsonContextfor source-generated JSON serialization, removings_jsonOptions.Codebreaker.GameAPIs.Client.csproj: Added<IsAotCompatible>property and updatedMicrosoft.Extensions.Logging.Abstractionsto version9.0.9.CreateGameRequest.cs: Removed conditional compilation forJsonStringEnumConverter.