-
-
Notifications
You must be signed in to change notification settings - Fork 119
separate backlog into sections #1687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cyf-programming ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-curriculum ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-launch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-common ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-piscine ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-sdc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-itd ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-tracks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
illicitonion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Also left a few comments on Slack
| <h2>Mandatory Tasks</h2> | ||
| <p>These tasks will help consolidate your learning for this sprint. You should complete as many of these as possible before class on Saturday.</p> | ||
| {{range $mandatoryTasks}} | ||
| <div class="c-alert" role="alert" hidden> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea what this alert is for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely no idea. I tried deleting it using Chrome devtools on a couple of pages at random, nothing broke so I'll just get rid of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in bfcf059.
| <span aria-hidden="true">×</span> | ||
| </button> | ||
| </div> | ||
| <details class="c-issue"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's pull out a partial for individual issues so we can just {{partial }} it rather than copy+pasting the <details> tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's the plan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added backlog-issue.html to partials in 49120fd.

What does this change?
This is work in progress - further changes likely
This separates the backlog pages for each sprint into three sections:
New labels have been added for issues which correspond to these categories:
RecurringCore(avoidingMandatoryfor now as there's already a label with a similar name, but can always change it later)OptionalAt time of writing I've only tested this ITP Onboarding so the majority of pages in the deploy preview will still be empty.
Common Content?
Common Theme?
Yes
Modifies
backlog.htmlto filter issues by priority then build each section in turn. This can definitely be improved, there's a lot of repetition currentlyUpdates the query in
issues-list-as-blocks.htmlto allow all labels to be pulled from the APIOrg Content?
Module|Sprint| Page Type |Block TypeChecklist
Who needs to know about this?
@illicitonion
@LonMcGregor
@Poonam-raj