Skip to content

phosphor to lumino #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 30, 2025
Merged

phosphor to lumino #34

merged 12 commits into from
Sep 30, 2025

Conversation

robobenklein
Copy link
Member

@robobenklein robobenklein commented Sep 28, 2025 •
edited
Loading

  • AccordionPanel is probably a replacement for ImprovedBoxPanel AccordionPanel comes with extra assumptions such as the renderer features that aren't strictly compatible with the DockLayout renderer, so it was easier just to fix the IBL
    • drag/resize seems to be broken anyways
  • Replacement of IDragEvent (deprecated, probly rework whole drag-drop at this point?)
  • drag to swap patch content not working
  • first line sometimes obscured because the breadcrumbs row is not always being taken into account by the sizer of TabPanel
  • bottom scrollbar takes up some pixels which is causing the horizontal one to show on RibbonPanel

@robobenklein robobenklein marked this pull request as ready for review September 30, 2025 03:53
@robobenklein robobenklein linked an issue Sep 30, 2025 that may be closed by this pull request
PhosphorJS status tracking #14
Closed
@robobenklein robobenklein merged commit 9e3ac9c into main Sep 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PhosphorJS status tracking
1 participant
@robobenklein