822: Fix deployment failure bug #823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temporarily disable release and release-drafter workflows
Fix "assigned a value but never used" errors.
Change severity of "no-explicit-any" and "no-unused-vars" rules from "error" to "warning."
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I merged this PR so I can get the changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #822 where merged PRs are failing to deploy to Vercel's preview and production environments. It appears that
npm run buildis failing due to new plugins recently added to .eslintrc.json. These plugins appear to enforce strict TypeScript-ESLint rules.This PR reduces the severity of two common TS rules. ESLint now issues a warning instead of throwing errors for them:
This PR also removes some unused variables.
How this was tested
Before reducing the rules' severity, running
npm run lintin local env produced these errors:After reducing their severity, running
npm run lintproduced warnings instead of errors: