Skip to content

Conversation

HeyZoos
Copy link
Contributor

@HeyZoos HeyZoos commented May 17, 2025

841d18c refactor: remove unused updateCurrentView callback
9ab43e0 feat: update reset button to dispatch 'CLEAR_DIMENSIONS'
4f94faf feat: change the 'X' button to say 'Reset'

Pull Request Title

Checklist:

Before submitting your PR, please confirm that you have done the following:

  • I have opened my PR against the staging branch, NOT against main
  • I've run the relevant formatting and linting tools listed in the setup docs
  • I have commented hard-to-understand areas in my code
  • I've reviewed any merge conflicts to make sure they are resolved
  • My changes generate no new warnings

Description

This PR replaces the X button with a Reset button that dispatches an event to clear filter state

Related Issue(s)

This PR addresses issue #1196

Type of change

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Screen.Recording.2025-05-17.at.11.46.18.AM.mov

Copy link

vercel bot commented May 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vacant-lots-proj ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2025 2:38pm

@HeyZoos HeyZoos closed this May 17, 2025
@HeyZoos HeyZoos reopened this May 17, 2025
@HeyZoos HeyZoos changed the base branch from main to staging May 17, 2025 15:56
@HeyZoos HeyZoos changed the title staging [1196] Filter reset button May 18, 2025
@nlebovits nlebovits merged commit 7dc2a82 into CodeForPhilly:staging May 19, 2025
5 checks passed
@HeyZoos HeyZoos deleted the staging branch May 19, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants