Fix backend formatting checks #1175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Before submitting your PR, please confirm that you have done the following:
staging
branch, NOT againstmain
Description
I noticed that the formatting check used in CI was lacking the
--check
flag forruff
. This meant that ruff formatted the files and exited with0
, even if there were files left to be formatted. Since this is used as a pre-commit hook where we do want to maintain automatic formatting, I opted to only override the command we pass to theformatter
container in Github actions. We may want to rework CI checks in the future. But this at least ensures we catch formatting errors in the short term.Type of change
How Has This Been Tested?
Since these were only formatting changes, I didn't add any new tests.