Fix: map search box opens profile for wrong addresses #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weekly PR from Staging to Main
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @CodeWritingCow I noticed there were a couple unused variables in |
|
Hi @vinhyan if they're unused, go ahead and remove them. Thank you! |
CodeWritingCow
approved these changes
Feb 15, 2025
|
@vinhyan is it possible to fix the bug without zooming down to the max level? i.e. Can we zoom down but still allow users to see the surrounding areas? Something like this: 
|
|
Ofc! I can play around with the zoom level later today. |
Weekly PR from Staging to Main
- Zooms in to prevent invisible layers which can cause inaccurate suggested properties.
vinhyan
force-pushed
the
vinhyan/1080-map-search-box-opens-profile-for-wrong-addresses
branch
from
05d0372 to
573a32e
Compare
|
@CodeWritingCow it is fixed, please review. I tested zooming any further than this may give inconsistent results. 1080-zoom16.mov |
|
@vinhyan this looks great. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Before submitting your PR, please confirm that you have done the following:
stagingbranch, NOT againstmainNote: used
--no-verifyflag when committing to bypasscross-spawnerror. (#1038)Description
The initial zoom map excludes some properties as they were not in the "visible layer", hence caused inaccurate results. To solve, simply zoom in when search to ensure the layer of the searched property is visible.
Zoom level is set to max for a more consistent result.
Related Issue(s)
This PR addresses issue #1080
Type of change
How Has This Been Tested?
CGP-1080.mov