Skip to content

fix: dont start perf unless it's not already started #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
Merged

fix: dont start perf unless it's not already started #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/run/runner/wall_time/perf/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,7 @@ impl PerfRunner {
.num_nanoseconds() as u64
};

let mut benchmark_started = false;
loop {
let perf_ping =
tokio::time::timeout(Duration::from_secs(perf_ping_timeout), perf_fifo.ping())
Expand Down Expand Up @@ -334,12 +335,25 @@ impl PerfRunner {
runner_fifo.send_cmd(FifoCommand::Ack).await?;
}
FifoCommand::StartBenchmark => {
if benchmark_started {
warn!("Received duplicate StartBenchmark command, ignoring");
runner_fifo.send_cmd(FifoCommand::Ack).await?;
continue;
}
benchmark_started = true;
markers.push(MarkerType::SampleStart(current_time()));

perf_fifo.start_events().await?;
runner_fifo.send_cmd(FifoCommand::Ack).await?;
}
FifoCommand::StopBenchmark => {
if !benchmark_started {
warn!("Received StopBenchmark command before StartBenchmark, ignoring");
runner_fifo.send_cmd(FifoCommand::Ack).await?;
continue;
}
benchmark_started = false;

markers.push(MarkerType::SampleEnd(current_time()));

perf_fifo.stop_events().await?;
Expand Down
Loading