Validate walltime results before uploading and error out if no bench found #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the section header with spinner to be redrawn multiple times in the middle of the line when the command prints data to stdout that is just a partial line.
There is still duplication between this and integrations for now.
GuillaumeLagrange
force-pushed
the
cod-1681-handle-walltime-runs-without-benchmarks-gracefully
branch
from
74985bd to
95c2017
Compare
adriencaccia
requested changes
Nov 14, 2025
GuillaumeLagrange
force-pushed
the
cod-1681-handle-walltime-runs-without-benchmarks-gracefully
branch
from
95c2017 to
a5a74e9
Compare
adriencaccia
approved these changes
Nov 17, 2025
GuillaumeLagrange
deleted the
cod-1681-handle-walltime-runs-without-benchmarks-gracefully
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155