Skip to content

Conversation

@art049
Copy link
Member

@art049 art049 commented Oct 22, 2025

Makes it possible to use newer builds of valgrind codspeed with an older runner

@art049 art049 requested a review from not-matthias October 22, 2025 10:23
@art049 art049 force-pushed the feat/better-valgrind-compatibility branch from 9d785f5 to 36cb3ba Compare October 22, 2025 10:25
Copy link
Member

@not-matthias not-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@not-matthias not-matthias requested a review from Copilot October 22, 2025 10:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the valgrind version checking logic to allow the runner to work with newer versions of valgrind-codspeed, rather than requiring an exact version match. The implementation uses semantic versioning to ensure backward compatibility while warning about experimental newer versions.

Key Changes:

  • Replaced string-based version checking with semantic version comparison using the semver crate
  • Changed version check from exact match to minimum version requirement
  • Added version parsing logic that handles various valgrind version string formats

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/run/runner/valgrind/setup.rs Implements semantic version parsing and comparison logic for valgrind versions, replacing exact string matching with minimum version requirements
src/main.rs Converts valgrind version constants from strings to semver Version type and introduces separate display string
Cargo.toml Adds semver dependency for semantic version handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@art049 art049 force-pushed the feat/better-valgrind-compatibility branch from e23e87f to 2b2dad8 Compare October 22, 2025 10:41
@art049 art049 force-pushed the feat/better-valgrind-compatibility branch from 2b2dad8 to c904fd8 Compare October 22, 2025 10:46
@art049 art049 merged commit c904fd8 into main Oct 22, 2025
5 checks passed
@art049 art049 deleted the feat/better-valgrind-compatibility branch October 22, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants