COD-1345: Do not gzip walltime reports #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
art049
requested changes
Sep 17, 2025
Comment on lines
+19
to
+24
|
|
||
| // Client without retry middleware for streaming uploads (can't be cloned) | ||
| pub static ref STREAMING_CLIENT: reqwest::Client = ClientBuilder::new() | ||
| .user_agent("codspeed-runner") | ||
| .build() | ||
| .unwrap(); |
Member
There was a problem hiding this comment.
would be great to find a way to have the retries even when streaming the body
Member
Author
There was a problem hiding this comment.
As seen in https://github.com/TrueLayer/reqwest-middleware/pull/51/files?w=1#diff-474abab8d90fcf4a3811b4faa74eff00faa8c9c190c9fd2e47991de8b2f4d64eR38-R49, it is not possible out of the box.
We will need to create a middleware manually that implements streaming. I will take a look
adriencaccia
force-pushed
the
cod-1345-do-not-gzip-walltime-reports
branch
2 times, most recently
from
17acd7e to
a92d6f5
Compare
art049
approved these changes
Sep 17, 2025
adriencaccia
force-pushed
the
cod-1345-do-not-gzip-walltime-reports
branch
from
a92d6f5 to
65a2980
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.