Skip to content

Conversation

@mangerlahn
Copy link
Contributor

Hi again,

thank you for quickly implementing platform_filters support. While this fixes my usage, I still get a warning when running xcodeproj:

[!] Xcodeproj doesn't know about the following attributes {"platformFilters"=>["macos"]} for the 'PBXTargetDependency' isa

I attempted to fix this myself, feel free to take a look.

@dnkoutso
Copy link
Contributor

@mangerlahn interesting so this exists for PBXTargetDependency as well.

Can you add a CHANGELOG entry as an enhancement please?

@mangerlahn
Copy link
Contributor Author

Done :)

@mangerlahn mangerlahn force-pushed the feature/platform_filters branch from bc83364 to 9f12ff4 Compare August 10, 2021 11:29
@dnkoutso
Copy link
Contributor

Seems like lint failed.

Inspecting 123 files
...............C...........................................................................................................

Offenses:

lib/xcodeproj/project/object/target_dependency.rb:32:1: C: Trailing whitespace detected.

123 files inspected, 1 offense detected
Error: Process completed with exit code 1.

You can run bundle exec rubocop -a at the root which should fix it.

@dnkoutso dnkoutso merged commit 5694e58 into CocoaPods:master Aug 10, 2021
@dnkoutso
Copy link
Contributor

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants