-
Notifications
You must be signed in to change notification settings - Fork 483
[PlistHelper] Fall back to XML project output when Xcode initializati… #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks good in general, but it seems to only work with Xcode 7, because |
|
BTW, this makes me think that it would be nice to have an env variable to completely disable loading of Xcode frameworks, so that users have an immediate workaround in case of breakage like this. I expected this to be a rather stable interface, but it evidently isn't. |
|
Another option would be to have a list of supported Xcode versions. The pro is that the user doesn’t need to know of an option that’s likely to be hard to find, the con is that it requires a CP update for new Xcode versions to work. |
|
Or you could do both and have the env variable also be available to enable the functionality when running on an unsupported Xcode version. |
|
@alloy that sounds like a better idea - finally we can have those compatibility UUIDs inside CP :) |
|
@neonichu lol, yah :D |
|
@neonichu want to take this over, then? |
|
@segiddins I would do the version detection as a separate PR - if you want, I can also finish this one. |
|
Yes please :) |
|
If there is going to be an option for this, it might also be nice to have a way to not suppress stderr when calling IDEInitialize(), so it is more obvious what the exact failure is without having to modify the Xcodeproj code. |
|
@ddunbar maybe, but i'd honestly prefer just to print it out when |
It is is only ever != 0 for Xcode 7, build 7A121l and newer (?), on older versions, we won't check the return value at all.
|
This should be good to merge now. It retains functionality for Xcode versions 7 beta 1 and earlier, while not breaking on 7 beta 2. However, it does not enable ASCII plist writing for 7 beta 2, opened #278 for tracking that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neonichu add yourself :)
|
👍 |
[PlistHelper] Fall back to XML project output when Xcode initializati…
…on fails.
Closes CocoaPods/CocoaPods#3723.