Skip to content

Conversation

@segiddins
Copy link
Member

…on fails.

Closes CocoaPods/CocoaPods#3723.

@neonichu
Copy link
Member

Looks good in general, but it seems to only work with Xcode 7, because IDEInitialize() returns 0 on previous versions, even when it is working.

@neonichu
Copy link
Member

BTW, this makes me think that it would be nice to have an env variable to completely disable loading of Xcode frameworks, so that users have an immediate workaround in case of breakage like this. I expected this to be a rather stable interface, but it evidently isn't.

@alloy
Copy link
Member

alloy commented Jun 24, 2015

Another option would be to have a list of supported Xcode versions. The pro is that the user doesn’t need to know of an option that’s likely to be hard to find, the con is that it requires a CP update for new Xcode versions to work.

@alloy
Copy link
Member

alloy commented Jun 24, 2015

Or you could do both and have the env variable also be available to enable the functionality when running on an unsupported Xcode version.

@neonichu
Copy link
Member

@alloy that sounds like a better idea - finally we can have those compatibility UUIDs inside CP :)

@alloy
Copy link
Member

alloy commented Jun 24, 2015

@neonichu lol, yah :D

@segiddins
Copy link
Member Author

@neonichu want to take this over, then?

@neonichu
Copy link
Member

@segiddins I would do the version detection as a separate PR - if you want, I can also finish this one.

@segiddins
Copy link
Member Author

Yes please :)

@neonichu neonichu self-assigned this Jun 24, 2015
@ddunbar
Copy link

ddunbar commented Jun 24, 2015

If there is going to be an option for this, it might also be nice to have a way to not suppress stderr when calling IDEInitialize(), so it is more obvious what the exact failure is without having to modify the Xcodeproj code.

@segiddins
Copy link
Member Author

@ddunbar maybe, but i'd honestly prefer just to print it out when IDEInitialize fails

It is is only ever != 0 for Xcode 7, build 7A121l and newer (?), on
older versions, we won't check the return value at all.
@neonichu
Copy link
Member

This should be good to merge now. It retains functionality for Xcode versions 7 beta 1 and earlier, while not breaking on 7 beta 2. However, it does not enable ASCII plist writing for 7 beta 2, opened #278 for tracking that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neonichu add yourself :)

@segiddins
Copy link
Member Author

👍

neonichu added a commit that referenced this pull request Jun 25, 2015
[PlistHelper] Fall back to XML project output when Xcode initializati…
@neonichu neonichu merged commit 43dae10 into master Jun 25, 2015
@neonichu neonichu deleted the seg-xcode7beta2 branch June 25, 2015 19:45
segiddins added a commit that referenced this pull request Jun 27, 2015
This reverts commit 43dae10, reversing
changes made to 3964e65.

# Conflicts:
#	lib/xcodeproj/plist_helper.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants