Add support for adding subprojects #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiopelosin
added a commit
that referenced
this pull request
Jul 27, 2014
Add support for adding subprojects
Member
There was a problem hiding this comment.
The proliferation of ‘helpers’ is ok, but they should be named more semantically. If this helper is responsible for changing case of a string, then I don’t think NameHelper really clarifies that. Also, ‘name’ doesn’t seem to be appropriate, isn’t it more like ‘keys’ ?
So how about something like PlistKeyCaseConverter?
Member
Author
There was a problem hiding this comment.
Is not about keys only but also the attributes of the objects. PlistCaseConverter works for me
Member
There was a problem hiding this comment.
Gotcha, maybe just CaseConverter then? The Plist part in my suggestion was about the ‘keys being those in the plist’.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.