CLANG_ENABLE_OBJC_WEAK = YES fails all the builds for apps using __weak

[vorobievalex]

Version 1.5.5 fails builds with:
clang: error: -fobjc-weak is not supported on the current deployment target

CLANG_ENABLE_OBJC_WEAK = YES added -fobjc-weak compilation option, what was disabled in project settings.

Regression of f356891

[segiddins]

Xcode 9.3 defaults CLANG_ENABLE_OBJC_WEAK to YES

[segiddins]

what deployment target does your target have?

[segiddins]

Looks like the mapping for deployment targets is:

case FragileMacOSX: return getVersion() >= VersionTuple(10, 7);
case MacOSX: return getVersion() >= VersionTuple(10, 7);
case iOS: return getVersion() >= VersionTuple(5);
case WatchOS: return true;

[segiddins]

Can you see if #546 fixes things for you? Thanks!

[nivanchikov]

@segiddins I'm also facing this issue on deployment target = 9.0. I didn't try lower or higher target versions. Maybe the issue is more related if MRC or ARC is used in specific pod library as opposed to making it a global setting?

[vorobievalex]

#546 helps. Could it be released, please?
Thanks a lot!

[vorobievalex]

Xcode 9.3 defaults CLANG_ENABLE_OBJC_WEAK to YES

The error appeared in some compiled pods.
For example https://github.com/TTTAttributedLabel/TTTAttributedLabel/blob/1.13.4/TTTAttributedLabel/TTTAttributedLabel.m
Explicitly setting this to NO in the app project does not help. Xcodeproj 1.5.5 overrides it.

what deployment target does your target have?

This affected several apps with deployment target 8.2, 9.0 and 10.3.

[segiddins]

Can you share a project I can use to reproduce the issue (if indeed #546 does not fix it)?

[vorobievalex]

@segiddins, #546 fixed this issue. Build succeed with this fix. Could it be released, please?
I just wanted to clarify earlier questions with my latest message above. Pardon for a miscommunication.

[segiddins]

Released

[vorobievalex]

@segiddins, thank you for a quick fix! Out team was able to quickly get back to the latest version of xcodeproj. Everything goes smoothly so far 👍