Skip to content

Conversation

@lepen-yang
Copy link
Collaborator

@lepen-yang lepen-yang commented Jul 16, 2023

What is the purpose of the change

finish issue #44

Related issues/PRs

Related issues: #44

Brief change log

solidui-web/scripts/webpack.base.js 【add svgr loader handle svg file】
solidui-web/src/index.d.ts 【rename to global.d.ts and fix module declaration】
solidui-web/src/pages/Designer/General/* 【finish #44 issue】
solidui-web/src/assets/icon/svg/*【this folder is used to store the svg icon】

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible
  • If this is a code change: I have written unit tests to fully verify the new behavior.

@lepen-yang lepen-yang requested a review from nutsjian July 16, 2023 16:01
Copy link
Collaborator

@nutsjian nutsjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@nutsjian nutsjian merged commit e4645c4 into CloudOrc:dev Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants