Skip to content

fix: issue73 #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dlimeng merged 1 commit into from
Sep 3, 2023
Merged

fix: issue73 #153

dlimeng merged 1 commit into from
Sep 3, 2023

Conversation

@nutsjian
Copy link
Collaborator

@nutsjian nutsjian commented Sep 3, 2023

What is the purpose of the change

fix issue #73, different model code use different message buffers

Related issues/PRs

Related issues: #73

Brief change log

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible
  • If this is a code change: I have written unit tests to fully verify the new behavior.

@nutsjian nutsjian requested a review from dlimeng September 3, 2023 15:53
dlimeng
dlimeng reviewed Sep 3, 2023
View reviewed changes
Copy link
Collaborator

@dlimeng dlimeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlimeng dlimeng merged commit e1fb492 into CloudOrc:dev Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlimeng dlimeng dlimeng left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nutsjian @dlimeng