Fix situation when a view full-refresh may remove another view if that view has '_mv' as suffix #536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A situation that we didn't controlled in #516. Related to #507
materialization: viewis created withhackersnamematerialization: materializaed_viewis created withhackers_mvname.hackers_mvand a CH MV calledhackers_mv_mvhackers-> Error is raised because the code is trying to drop the viewhackers_mvbut that's a table. if it were a view, we would have been removing it :(The Error came on the new code we added to drop the MVs:
hackersworks ok: it doesn't find MVs._mvthing available, even if it doesn't make senseChanges:
clickhouse__drop_mvs_with_namesmacro and send to it the filtered list of names to drop so now it doesn't include already filtered ones.