Skip to content

Conversation

charleskawczynski
Copy link
Member

It seems that whatever JuliaLang/julia#35948 is changing results in Base.Broadcast.BroadcastStyle getting called with a different order of arguments. I thought that Julia was supposed to swap and try both, but I don't recall where in the docs.

@charleskawczynski charleskawczynski merged commit e47f373 into main May 20, 2025
35 checks passed
@charleskawczynski charleskawczynski deleted the ck/2329 branch May 20, 2025 21:11
@marius311
Copy link

Would it be possible for you to create a MWE showing where my PR makes it necessary to define both orders? That shouldn't be happening. The place in the docs I think you're thinking of is here: https://docs.julialang.org/en/v1/manual/interfaces/#writing-binary-broadcasting-rules

It could be that what you're seeing is just the need to define the Val constructor correctly masquerading as needing both orders.

@charleskawczynski
Copy link
Member Author

Would it be possible for you to create a MWE showing where my PR makes it necessary to define both orders? That shouldn't be happening. The place in the docs I think you're thinking of is here: https://docs.julialang.org/en/v1/manual/interfaces/#writing-binary-broadcasting-rules

It could be that what you're seeing is just the need to define the Val constructor correctly masquerading as needing both orders.

I'm not actually sure where the error came from, as the reported stack trace was quite truncated. But if someone can report a stack trace, I can look into it if I have the bandwidth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants