-
Notifications
You must be signed in to change notification settings - Fork 302
feature: adding spacebar to toggle maximising/minimising of tree mode nodes #1830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I have not added my changes to handle_char as space shouldn't be considered a char(?), but as crossterm didn't have an enum for Space I am (mis)using KeyCode::Char to get Spacebar info. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1830 +/- ##
=======================================
Coverage 36.18% 36.18%
=======================================
Files 115 115
Lines 16325 16324 -1
=======================================
Hits 5907 5907
+ Misses 10418 10417 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @ClementTsang, I just wanted to check in to see if there’s anything else you’d like me to change in the PR. Thanks! |
|
Sorry for the delay, my bad! I'll review it in a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, hm, I think I should have been more clear on what that issue was asking - it was for toggling whether an entry was minimized/maximized. Apologies for not being more clear, updated that issue.
|
Yeah, basically the space key does what clicking on the entry would do (or the +/- key), toggle between maximized and minimized states. |
|
Great, I’ve added the code to support that. For the case where the space key is pressed while the program is in a dialog, should it perform any action? I was thinking it could either scroll to the next option or select the current one. |
|
I’m planning to use the - and + keys to collapse and expand all entries, respectively. |
|
Hi, I believe the implementation is now complete. I’ve added a few new features, including full collapse and expansion of the tree.
The idea behind using ‘-’ and ‘+’ is to make it easier to navigate through the process IDs in the tree view. |


Description
Adds space key as a toggle for maximizing/minimizing nodes inside process tree mode,
Issue
#1808
Closes: #
Testing
The tests were run on Linux only.
Checklist
If relevant, ensure the following have been met:
cargo fmt)README.md, help menu, doc pages, etc.)