Skip to content

Conversation

@ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Aug 31, 2025

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@codecov
Copy link

codecov bot commented Aug 31, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.77%. Comparing base (f1017d6) to head (73edcd9).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/collection.rs 0.00% 3 Missing ⚠️
src/collection/processes/unix/process_ext.rs 0.00% 1 Missing ⚠️
src/collection/processes/unix/user_table.rs 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f1017d6) and HEAD (73edcd9). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f1017d6) HEAD (73edcd9)
ubuntu-latest 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1807      +/-   ##
==========================================
- Coverage   42.12%   36.77%   -5.35%     
==========================================
  Files         115      107       -8     
  Lines       16215    14971    -1244     
==========================================
- Hits         6830     5506    -1324     
- Misses       9385     9465      +80     
Flag Coverage Δ
macos-14 37.35% <0.00%> (-0.01%) ⬇️
ubuntu-latest ?
windows-2022 37.69% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ClementTsang ClementTsang marked this pull request as ready for review September 1, 2025 07:01
@ClementTsang ClementTsang force-pushed the some_optimizations_for_linux_data_collection branch from 1bc15c4 to 7b88dbe Compare September 1, 2025 08:43
@ClementTsang
Copy link
Owner Author

The bug fix is needed, but iffy on the read_link stuff.

@ClementTsang
Copy link
Owner Author

(as the slow part seems to be with the readlink itself no matter what)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant