Mod options scrollbar position fix #722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvakvs
reviewed
Feb 21, 2020
Collaborator
kvakvs
left a comment
kvakvs
left a comment
There was a problem hiding this comment.
Some magical numbers everywhere. Can't that be based on something reliable? Like row height, panel height, or something?
Member
Author
|
Don't you know that I love magic numbers? 😄 Good point, I will try to make it better, maybe I'll make a little refactor there :) |
kvakvs
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes weird positioning of scrollbar.
Before:
After:
