Pimped-up lane hover !

[kianzarrin]

fixes #625

See #625 (comment) for pictures

• As agreed in Lane connector: Hovering over lane points is difficult when cars and roads are passing over. #543 (comment) I make the whole lane hover-able.

• Visual feedback: If mouse pointer is on circle of the node lane marker then I don't highlight the whole lane. If the mouse pointer is on the lane but not on the circle, then I highlight the whole lane. This conditional display lane overlay is an answer to lane connector should raycast the whole lane #625 (comment)
  selected and hovered lanes (source or target) get Sheath overlay. I didn't change the color ... just the shape.

• I revived the lane hovering code from Traffic ++

• I made performance optimization by caching mouse pointer and lane bounds. They are recalculated only if user moves the mouse ray.

fixes #543

• I fixed the vertical mismatch by intersecting the mouse ray at the place where it hits the road.

• hitPos error: raycasting returns hitpos with error. it is as if the mouse ray penetrates the road segment a little bit. This error is partially mitigated by calling GetClosestLanePosition(). the returned vertical position still has less error and it does not cause any practical problem.

• the fixed position takes 100us to calculate. So I cached it and it only recalculated if user moves the mouse ray.

EDIT: In the old code it is possible to turn the camera so extreme that two markers are hovered. I added a check to avoid that.

EDIT: fixed lane curves:

• TMPE does not draw lane curves for metros. I fixed that.
• also draw lane curve when mouse is not hovering over anything.

EDIT: for monorail I no longer hover rail projections on the ground, but rather I hover the road lane it self.

EDIT: train markers are both source and target and used to be rendered with white color even if they were the source of the selection. I fixed that to use original color. see #635 (comment)

EDIT: sometimes lane curves get berried under other lane curves. To mitigate this problem I render curves from selected lane on top of all others.
#635 (comment)

[originalfoo]

Regarding caching: If I'm moving the mouse over the screen, it doesn't really need to recalculate on every frame. Maybe add a de-spam of 250ms between refreshes? (inperceptible to most humans)

Also, what happens if user changes camera view via keyboard (eg. cursor keys; no mouse movement)? That should invaldiate cache.

The mouse/camera delta & de-spam caching mechanism would be super-useful for lots of other things too, for example caching of visible nodes/segments for persistent overlays, etc.

[kianzarrin]

@aubergine10

Also, what happens if user changes camera view via keyboard (eg. cursor keys; no mouse movement)? That should invaldiate cache.

Mouse ray will change ... I think. To be honest I don't know what exactly is mouse ray. I am checking for mouse position on terrain and THAT will change if you move the screen.

[originalfoo]

Downside to showing all outgoing sheaths for current incoming lane is when I want to remove an existing connection.

Maybe if connected-but-not-hovered outgoing lane was given same colour sheath as the incoming lane. If I hover an outgoing lane, it's sheath would turn white, whether connected or not?

Or....

When hovering non-connected outgoing lane, it gets white sheath. When connected to currentluy-selected incoming lane, the outgoing sheath remains white (while assocaited incoming lane still selected). But if I then hover an already-connected outgoing lane (for currently selected incoming lane), the outgoing sheath takes on colour of the incoming lane indicating that if I click that outgoing lane the wire is going to get reeled back in to the incoming lane (ie. disconnected from that outgoing lane).

Same could be done with the "wire": Dragged wire (following mouse) = white = "stick me in a white hole / sheath". Connected wire = white = distinguishes the currently active wires (for selected incoming lane) from any others on the junction/node (as they are all coloured). But if I then hover over already-connected (to currently selected incoming lane) outgoing lane, the wire turns same colour as incoming lane = "that's where it's going if you click now - back to the coloured lane" = connection will break.

Hope that makes even a remote amount of sense lol

[originalfoo]

Minor buglet (can be left to future PR) - station track source sheaths are white:

EDIT: That's train station using RWY (Railway) rail tracks and station tracks.

It's bit of weird scenario because station tracks are both incoming and outgoing lanes.

[kianzarrin]

@aubergine10 When hovering non-connected outgoing lane, it gets white sheath. When connected to currentluy-selected incoming lane, the outgoing sheath remains white (while assocaited incoming lane still selected). But if I then hover an already-connected outgoing lane (for currently selected incoming lane), the outgoing sheath takes on colour of the incoming lane indicating that if I click that outgoing lane the wire is going to get reeled back in to the incoming lane (ie. disconnected from that outgoing lane).

incoming is ambiguous. is it incoming lane from the junction or toward the junction? depends on where the observer is. is it source? is it target?

I don't mind doing it but I would like there to be discussion rather than last minute rush. lets do it in another review.

I will fix the white train station sheath issue

[kianzarrin]

Minor buglet (can be left to future PR) - station track source sheaths are white:

EDIT: That's train station using RWY (Railway) rail tracks and station tracks.

It's bit of weird scenario because station tracks are both incoming and outgoing lanes.

Well spotted! I changed half a line of code. should be fixed now:

[kianzarrin]

@aubergine10

Here is a better illustration of why I'd like outgoing sheaths shown for currently selected incoming lane.

I have red incoming lane connected to 2 outgoing lanes, but only one is clearly visible. If both connected outgoing lanes had sheath, it would be very obvious which lanes red incoming lane connects to.
If I deselect the red incoming lane, the outgoing lanes it connects to would remove their sheaths. Hope that makes sense. :)

Oops almost didn't see this one. github confuses me. sometimes I don't see messages.
Fixed it! I draw the lane curves to the selected marker last so that they are on top. also they are emboldened with different (grey) border color.

We can discuss all those complex Lane sheath stuff in another PR if that is OK.

[originalfoo]

Create issue with all the future ideas: #670

[originalfoo]

@krzychu124 any feedback on code, etc? this PR is read for merge pending your review

[kvakvs]

Style/comment notes remaining

[originalfoo]

See kvakvs' comments above

[kvakvs]

Nice

[originalfoo]

LGTM 👍

[originalfoo]

@krzychu124 this is ready to merge - any comments?

[originalfoo]

Something's gone fubar with latest commit - see images below...

[originalfoo]

When I click on this blue lane:

The exiting line connecting to the outgoing lane goes mental:

Green lane is same:

Looks like it's adding about 5 lane connector wires for each connected outgoing lane.

Seems to be happening on all my roads.

Station tracks are fixed though :)

Looks like the station track fix broke all the other types of lane connector...

[kianzarrin]

@aubergine10 Looks like the station track fix broke all the other types of lane connector...

It can't be! I tested it and it worked ... look: #635 (comment)

Ill test it out again.

OK fixed it. see diff. its one line fix with level of for loop.

[originalfoo]

LGTM 👍 Working great now!

[krzychu124]

Testing...