Skip to content

Conversation

@kvakvs
Copy link
Collaborator

@kvakvs kvakvs commented Sep 21, 2019

  • Change color palette to distinct color set, and only allocate colors for source lanes (previously both source and target lanes got allocated a color even though target lanes did not need a color).
  • Render target lanes as white circles.
  • Render black outline around the lane connectors, and black outline around node circles.
  • Render white outline and use brighter color of the same hue, while dragging a curve

image

Contributes to #523

@kvakvs kvakvs changed the title Facelift lane connectors add outline [Facelift] Lane Connectors now have contrast outlines Sep 21, 2019
@originalfoo
Copy link
Member

This looks good! Is it possible to make the outlines slightly thinner?

@kvakvs
Copy link
Collaborator Author

kvakvs commented Sep 25, 2019

Of course possible, there is a fixed thickness offset used (and for circles a multiplier is used).

It though behaves slightly strange, there is no clean overdraw if i render two things on top of each other, it feels like overlays are grouped by color or something (by Unity), i.e. render order of overlays seems to change.

One more thing to consider, if i zoom out, those overlays may look like they have flickering black grain borders, because the border becomes narrower than 1 pix. I have not tested this because overlays disappear when the camera zooms out.

@kvakvs
Copy link
Collaborator Author

kvakvs commented Sep 25, 2019

Here's with black curve width multiplier 1.5f (was 2f * colored curve width)

image

Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@originalfoo originalfoo added Accessibility Color blindness, etc. LANE ROUTING Feature: Lane arrows / connectors Overlays Overlays, data vis, etc. UI User interface updates labels Sep 25, 2019
@originalfoo originalfoo added this to the 11.0 milestone Sep 25, 2019
Copy link
Member

@krzychu124 krzychu124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kvakvs kvakvs merged commit 5201cee into CitiesSkylinesMods:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accessibility Color blindness, etc. LANE ROUTING Feature: Lane arrows / connectors Overlays Overlays, data vis, etc. UI User interface updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants