Speed limits: Unlimited speed display fix; Unlimited default speed fix

[kvakvs]

Fixes #446 -- Restores behaviour of TM:PE 10.20

• Speed limit of 0 is shown as 🚫 unlimited
• Speed limit greater than available textures is shown as 🚫 unlimited
• Speed limits below 5 show as 5 km/mph

Allows selecting 🚫 unlimited for default speed limits

[krzychu124]

LGTM 👍

[krzychu124]

Hmm, which speed limit sign I should expect to see when road/train track has 3.0 limit(game speed)?

[kvakvs]

Hmm, which speed limit sign I should expect to see when road/train track has 3.0 limit(game speed)?

That is 150 kmph for rail, in 10.20 it was showing as 🚫 if i remember correctly?

[krzychu124]

Ok, tested again. It's working as it should (I've built wrong PR 😄 )

[kvakvs]

One problem: Clicking Left in default speeds UI will switch between 10 and 🚫 and 10 again etc.
If this is undesired behaviour it is probably a good time to fix it today.
I believe we will revisit this tool in v11 UI revamp anyway.

[originalfoo]

testing...

[krzychu124]

Yup, would be nice to fix that 10 - 🚫 issue.
Maybe we should add 🚫 when user click left from 10 km/h and right when on 140 km/h?

[originalfoo]

The normal speeds UI seems to be working fine. My train tracks are showing 'no limit' sign, and I can set roads to 'no limit' too.

In default speeds UI, right-clicking multiple times ends up at 90 MPH - I would expect it to continue on to 'no limit' with an additional right-click as 'no limit' to me is semantically faster than 90 MPH.

I also noticed the left-clicking issue mentioned by @kvakvs above where it toggles between 5 MPH and 'no limit' signs. IMO it should stop at 5 MPH when left clicking.

[kvakvs]

Now clicking ⬅ on 5 mph (10 km) will show 🚫 and wrap over to 90 mph (140 km)
Now clicking ➡ on 90 mph (140 km) will show 🚫 and wrap over to 5 mph (10 km)

[originalfoo]

This works great now!

LGTM 👍