C# Source Modernization initiative #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvakvs
added
code cleanup
originalfoo
reviewed
Jul 16, 2019
originalfoo
reviewed
Jul 16, 2019
originalfoo
reviewed
Jul 16, 2019
kvakvs
force-pushed
the
419-modernisation
branch
from
e19f66d to
57f70d6
Compare
originalfoo
reviewed
Jul 18, 2019
originalfoo
reviewed
Jul 18, 2019
originalfoo
reviewed
Jul 18, 2019
kvakvs
added
under-review
krzychu124
approved these changes
Jul 19, 2019
Member
krzychu124
left a comment
krzychu124
left a comment
There was a problem hiding this comment.
LGTM 👍 Tested in-game, no issues.
Member
|
Since we are reviewing this PR would be nice to change it's state to 'Ready for review' 😉 |
VictorPhilipp
previously requested changes
Jul 20, 2019
originalfoo
reviewed
Jul 21, 2019
originalfoo
reviewed
Jul 21, 2019
originalfoo
reviewed
Jul 21, 2019
kvakvs
dismissed
VictorPhilipp’s stale review
I have addressed and responded to all notes except the multiline comments
2 tasks
originalfoo
added
technical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE
This PR does not add, modify or remove features. This PR features code formatting, logging and quality of life changes to the developer experience.
Changes
This PR only includes files from
CSUtil.CommonsandTLM/CustomFor every file in TLM:
varbecomes explicit type (solves Enforce stating explicit types #436, debatable)var Xxxused inout Xxxargs, are inlined intoout var Xxx(latest C#)[UsedImplicitly]to get rid of the warning#if DEBUG if (condition) Log._Debug #endifchanged to something shorter (solves Improve code readability by simplifying debug logging #349)