Skip to content

Explicitly Set C# Version to Latest #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2019
Merged

Explicitly Set C# Version to Latest #398

merged 3 commits into from
Jun 30, 2019

Conversation

@krzychu124
Copy link
Member

@krzychu124 krzychu124 commented Jun 28, 2019

Explicitly set C# language version to 7.3

Now you can use inline out variable and other stuff from the latest C# language version.

Fixed CI build agent.

@krzychu124 krzychu124 added the technical Tasks that need to be performed in order to improve quality and maintainability label Jun 28, 2019
@krzychu124 krzychu124 added this to the 10.21 milestone Jun 28, 2019
@krzychu124 krzychu124 requested a review from originalfoo June 28, 2019 23:02
@krzychu124 krzychu124 self-assigned this Jun 28, 2019
@FireController1847 FireController1847 changed the title C# version set to 7.3 explicitly Explicitly Set C# Version to 7.3 Jun 28, 2019
originalfoo
originalfoo approved these changes Jun 28, 2019
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dymanoid
Copy link
Contributor

dymanoid commented Jun 29, 2019

Maybe set the version to <LangVersion>latest</LangVersion>? When C# 8 will become available, you won't need to change the setting anymore.

@krzychu124
Copy link
Member Author

krzychu124 commented Jun 29, 2019

Maybe set the version to <LangVersion>latest</LangVersion>? When C# 8 will become available, you won't need to change the setting anymore.

Good point, I will update that ;)

@krzychu124 krzychu124 requested a review from originalfoo June 30, 2019 20:10
originalfoo
originalfoo approved these changes Jun 30, 2019
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krzychu124
Copy link
Member Author

krzychu124 commented Jun 30, 2019

BTW, I've skipped lang change in OptionsFramework and CSUtil.CameraControl projects.
I will update them later when we release 10.21, because I think it would break some PR's (commit pointer would be different)

FireController1847
FireController1847 approved these changes Jun 30, 2019
View reviewed changes
Copy link
Collaborator

@FireController1847 FireController1847 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FireController1847 FireController1847 changed the title Explicitly Set C# Version to 7.3 Explicitly Set C# Version to Latest Jun 30, 2019
@FireController1847 FireController1847 merged commit 1e437c9 into master Jun 30, 2019
@krzychu124 krzychu124 deleted the explicit-csharp-version branch July 27, 2019 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@originalfoo originalfoo originalfoo approved these changes

@FireController1847 FireController1847 FireController1847 approved these changes

Assignees

@krzychu124 krzychu124

Labels

technical Tasks that need to be performed in order to improve quality and maintainability

Projects

None yet

Milestone

10.21

Development

Successfully merging this pull request may close these issues.

5 participants

@krzychu124 @dymanoid @originalfoo @FireController1847