Skip to content

Minor fixes: Saving/Loading junction restrictions, UI overlay, Reset stuck cims #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2019
Merged

Minor fixes: Saving/Loading junction restrictions, UI overlay, Reset stuck cims #358

merged 1 commit into from
Jun 8, 2019

Conversation

@VictorPhilipp
Copy link
Collaborator

@VictorPhilipp VictorPhilipp commented Jun 7, 2019

Fixes #351

@VictorPhilipp
- Fixed minor issues regarding saving/loading junction restrictions
bb85e62 
- Bugfix: Changes of default junction restrictions are not reflected in the UI overlay
- Bugfix: Resetting stuck cims unpauses the simulation (#351)
@VictorPhilipp VictorPhilipp added LABS TM:PE LABS branch STABLE TM:PE STABLE branch labels Jun 7, 2019
@VictorPhilipp VictorPhilipp added this to the 10.21 milestone Jun 7, 2019
@VictorPhilipp VictorPhilipp requested a review from originalfoo June 7, 2019 21:14
originalfoo
originalfoo approved these changes Jun 8, 2019
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@originalfoo
Copy link
Member

originalfoo commented Jun 8, 2019

Need to do some more testing on this - had some weird glitches but a few other mods were just updated so possibly caused by them. Please don't merge until I can confirm the glitches were external factors.

@originalfoo
Copy link
Member

originalfoo commented Jun 8, 2019 •
edited
Loading

Good news, it's not TM:PE, so this can be merged.

Narrowing down recently updated mods:

  • Watch It - bit broken by latest update, but not causing the issues
    • Causes issues with Mod Tools
  • Real Time - seems fine
  • Snooper - seems fine
  • Resize It - seems fine
  • Hide It - seems fine, recent update fixed log spam
  • Show It - minor bug in recent update caused panel opacity to default to 0

Seems most the issues were due to recent updates to Keallu's mods.

I'm still trying to track down last few issues, going to test again with TMPE.

@originalfoo
Copy link
Member

originalfoo commented Jun 8, 2019

Tested every combination of the recent updates with and without TMPE. Bulk of issues form recent update to "Watch It" mod, and some from "Show It" mod.

TM:PE is 👍

@VictorPhilipp
Copy link
Collaborator Author

VictorPhilipp commented Jun 8, 2019

Thanks for the extensive testing!!

@VictorPhilipp VictorPhilipp merged commit cec8307 into master Jun 8, 2019
@VictorPhilipp VictorPhilipp mentioned this pull request Jun 8, 2019
Merged
@originalfoo originalfoo mentioned this pull request Jun 8, 2019
Open
@originalfoo originalfoo mentioned this pull request Jun 27, 2019
Closed
@originalfoo originalfoo added the Settings Road config, mod options, config xml label Aug 13, 2019
@originalfoo originalfoo deleted the minor-fixes branch September 4, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@originalfoo originalfoo originalfoo approved these changes

Assignees

No one assigned

Labels

LABS TM:PE LABS branch Settings Road config, mod options, config xml STABLE TM:PE STABLE branch

Projects

None yet

Milestone

10.21

Development

Successfully merging this pull request may close these issues.

Reset stuck cims (maintenance tab) unpauses game

3 participants

@VictorPhilipp @originalfoo