Skip to content

Improve reliability of Custom Path Manager when patched by other mods #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 20, 2023
Merged

Improve reliability of Custom Path Manager when patched by other mods #1727

merged 4 commits into from
Mar 20, 2023

Conversation

@krzychu124
Copy link
Member

@krzychu124 krzychu124 commented Mar 7, 2023 •
edited
Loading

  • implement CustomPathManager reinitialization,
  • improve pathfind lifecycle logging

Build zip

@krzychu124
Implement CustomPathManager Reinitialization.
f79bafb 
Improve pathfind lifecycle logging.
@krzychu124 krzychu124 added high priority Affects lots of users confirmed Represents confirmed issue or bug STABLE TM:PE STABLE branch PATHFINDER Pathfinding tweaks or issues COMPATIBILITY Mod (in)compatibility / checker Harmony regression old bug comes back or a new bug introduced in code that used to work. TEST TEST version of the mod / workshop page labels Mar 7, 2023
@krzychu124 krzychu124 added this to the 11.7.4.0 milestone Mar 7, 2023
@krzychu124 krzychu124 self-assigned this Mar 7, 2023
@krzychu124 krzychu124 removed this from the 11.7.4.0 milestone Mar 7, 2023
@krzychu124 krzychu124 marked this pull request as ready for review March 15, 2023 03:52
@krzychu124 krzychu124 added this to the 11.7.4.0 milestone Mar 16, 2023
kvakvs
kvakvs approved these changes Mar 19, 2023
View reviewed changes
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lot of logging happening here, hope its not in the hot paths

@krzychu124
Copy link
Member Author

krzychu124 commented Mar 19, 2023

Reinitialize will be (optionaly) triggered by the More Path Units mod if you have it installed and enabled right after you select a savegame to load or start new game. It was very hard/unreliable to reinitialize patched things in pathfinding which TM:PE needs to use, like e.g.: arrays with increased item count.

@krzychu124 krzychu124 merged commit 8db3a61 into master Mar 20, 2023
@krzychu124 krzychu124 deleted the bugfix/reinitialize-pathmanager-compatibility branch March 20, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kvakvs kvakvs kvakvs approved these changes

@kianzarrin kianzarrin Awaiting requested review from kianzarrin

@chameleon-tbn chameleon-tbn Awaiting requested review from chameleon-tbn

@DaEgi01 DaEgi01 Awaiting requested review from DaEgi01

Assignees

@krzychu124 krzychu124

Labels

COMPATIBILITY Mod (in)compatibility / checker confirmed Represents confirmed issue or bug Harmony high priority Affects lots of users PATHFINDER Pathfinding tweaks or issues regression old bug comes back or a new bug introduced in code that used to work. STABLE TM:PE STABLE branch TEST TEST version of the mod / workshop page

Projects

None yet

Milestone

11.7.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@krzychu124 @kvakvs