Skip to content

Conversation

@kianzarrin
Copy link
Collaborator

@kianzarrin kianzarrin commented Oct 10, 2022

TMPE.zip
fixes #1497 see issue

Test

created a setup like this video https://youtu.be/EqkzznhV6hc?t=760
result:

  • prev code: step3 did not wait for pedestrians to pass
  • fixed code: step3 properly waits for pedestrian to pass

side effects

the fix is guarded by ChangeMetric != StepChangeMetric.NoWait so it has not effect on other change metrics.

hide slider when redundant
reorder criteria by importance.
@kianzarrin kianzarrin added BUG Defect detected TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc labels Oct 10, 2022
@kianzarrin kianzarrin self-assigned this Oct 10, 2022
@kianzarrin kianzarrin changed the base branch from master to TTL-UI-redundancy October 10, 2022 18:44
@krzychu124 krzychu124 added this to the 11.8.0 milestone Oct 10, 2022
Copy link
Contributor

@chameleon-tbn chameleon-tbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Base automatically changed from TTL-UI-redundancy to master October 12, 2022 13:40
@kianzarrin kianzarrin merged commit 5ea096b into master Oct 12, 2022
@kianzarrin kianzarrin deleted the TTL-wait-bug branch October 12, 2022 14:07
@krzychu124 krzychu124 modified the milestones: 11.8.0, 11.7.2.0 Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BUG Defect detected TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Timed-traffic light step switch condition wait = 0 always evaluating as True

4 participants