Add support for OpenAI's gpt-5.1-chat-latest model #905
Conversation
Summary of ChangesHello @PeterDaveHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates support for OpenAI's recently announced Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughAdded a new ChatGPT API model key Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Compliance Guide 🔍(Compliance updated until commit f3cdbf7)Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label Previous compliance checksCompliance check up to commit f3cdbf7
|
||||||||||||||||||||||||||||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
|
@codex review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly adds support for the new gpt-5.1-chat-latest model. The changes are straightforward and functionally correct. I've added a couple of comments regarding the ordering of models in the configuration file. While the current placement is logical within the immediate context, it contributes to a growing inconsistency in the overall model list. Addressing this would improve the long-term maintainability of the code. Apart from that, the changes look good.
| 'chatgptApi4o_128k', | ||
| 'chatgptApi4oLatest', | ||
| 'chatgptApi5Latest', | ||
| 'chatgptApi5_1Latest', |
There was a problem hiding this comment.
While adding the new model here is logical, it places the gpt-5 models between gpt-4o models (chatgptApi4oLatest on line 54 and chatgptApi4oMini on line 57), which can be confusing for future maintenance. To improve readability, it would be better to group all models of the same family together. A small refactoring to group all gpt-4o models before the gpt-5 models would be an improvement.
| }, | ||
| chatgptApi4oLatest: { value: 'chatgpt-4o-latest', desc: 'ChatGPT (ChatGPT-4o latest)' }, | ||
| chatgptApi5Latest: { value: 'gpt-5-chat-latest', desc: 'ChatGPT (ChatGPT-5 latest)' }, | ||
| chatgptApi5_1Latest: { value: 'gpt-5.1-chat-latest', desc: 'ChatGPT (ChatGPT-5.1 latest)' }, |
There was a problem hiding this comment.
The ordering in the Models object is also becoming inconsistent. For instance, gpt-4.1 models are defined after gpt-5.1. While this is a pre-existing issue, for better maintainability, it would be beneficial to group these model definitions by family. A follow-up task to refactor the order would be valuable.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for OpenAI's gpt-5.1-chat-latest model by registering it in the ChatGPT API configuration, enabling users to select this model alongside existing options.
- Adds the
chatgptApi5_1Latestmodel key to the chatgptApiModelKeys array - Registers the new model with identifier
gpt-5.1-chat-latestand descriptionChatGPT (ChatGPT-5.1 latest)in the Models registry
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
PeterDaveHello
deleted the
codex/add-support-for-gpt-5.1-chat-latest-model
branch
User description
Summary
Testing
Codex Task
PR Type
Enhancement
Description
Add support for OpenAI's gpt-5.1-chat-latest model
Register new model in ChatGPT API configuration
Enable model selection alongside existing gpt-5 entry
Diagram Walkthrough
File Walkthrough
index.mjs
Register gpt-5.1-chat-latest model in configurationsrc/config/index.mjs
chatgptApi5_1Latestto thechatgptApiModelKeysarraygpt-5.1-chat-latestanddescription
ChatGPT (ChatGPT-5.1 latest)in Models registrychatgptApi5LatestentrySummary by CodeRabbit