-
Notifications
You must be signed in to change notification settings - Fork 144
feat(client/consensus/grandpa): BlockImport
implementation for GRANDPA
#4762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlockImport
implementation for GRANDPA
dimartiro
reviewed
Jun 17, 2025
haikoschol
approved these changes
Jun 17, 2025
BlockImport
implementation for GRANDPABlockImport
implementation for GRANDPA
77f5ccd
to
ec119a5
Compare
888deb5
to
6a2365d
Compare
axaysagathiya
approved these changes
Jun 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c9441a9
to
76c5024
Compare
6a2365d
to
a91dfa8
Compare
76c5024
to
363f4b7
Compare
a91dfa8
to
f9fc433
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
GrandpaBlockImport
implementation. Implements thecommon.BlockImport
interface and is intended to be called before persisting a block in theClient
.Client
implementation ofcommon.BlockImport
is called by the GRANDPA client integration.grandpa.ConsensusLog
primitivesfeat/grandpa
to persist authority sets.Tests
go test -tags integration github.com/ChainSafe/gossamer
Issues
closes #3642