Skip to content

Conversation

timwu20
Copy link
Contributor

@timwu20 timwu20 commented Jun 9, 2025

Changes

  • GrandpaBlockImport implementation. Implements the common.BlockImport interface and is intended to be called before persisting a block in the Client. Client implementation of common.BlockImport is called by the GRANDPA client integration.
  • Introduces grandpa.ConsensusLog primitives
  • Copies over some auxiliary schema helper functions from feat/grandpa to persist authority sets.

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

closes #3642

@timwu20 timwu20 marked this pull request as ready for review June 9, 2025 19:06
@timwu20 timwu20 changed the title BlockImport impl feat(client/consensug/grandpa): BlockImport implementation for GRANDPA Jun 9, 2025
@timwu20 timwu20 changed the title feat(client/consensug/grandpa): BlockImport implementation for GRANDPA feat(client/consensus/grandpa): BlockImport implementation for GRANDPA Jun 19, 2025
@timwu20 timwu20 force-pushed the tim/grandpa-voterwork branch from 77f5ccd to ec119a5 Compare June 19, 2025 17:32
@timwu20 timwu20 requested a review from P1sar as a code owner June 19, 2025 17:32
@timwu20 timwu20 force-pushed the tim/grandpa-block-import branch 3 times, most recently from 888deb5 to 6a2365d Compare June 19, 2025 22:46
@timwu20 timwu20 requested a review from dimartiro June 20, 2025 15:08
Copy link
Contributor

@axaysagathiya axaysagathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timwu20 timwu20 force-pushed the tim/grandpa-voterwork branch from c9441a9 to 76c5024 Compare July 2, 2025 20:01
@timwu20 timwu20 force-pushed the tim/grandpa-block-import branch from 6a2365d to a91dfa8 Compare July 2, 2025 20:03
@timwu20 timwu20 force-pushed the tim/grandpa-voterwork branch from 76c5024 to 363f4b7 Compare July 3, 2025 14:43
Base automatically changed from tim/grandpa-voterwork to development July 3, 2025 19:24
@timwu20 timwu20 force-pushed the tim/grandpa-block-import branch from a91dfa8 to f9fc433 Compare July 4, 2025 13:59
@timwu20 timwu20 merged commit a6e2d81 into development Jul 4, 2025
23 of 28 checks passed
@timwu20 timwu20 deleted the tim/grandpa-block-import branch July 4, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BlockImport implementation
4 participants