chore(blockstate): change GetRuntime to take common.Hash as argument
#2759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
changed the title
GetRuntime GetRuntime to take common.Hash as argument
qdm12
force-pushed
the
qdm12/blockstate/getruntime
branch
3 times, most recently
from
d9ff75e to
3bde739
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #2759 +/- ##
===============================================
+ Coverage 63.13% 63.14% +0.01%
===============================================
Files 219 219
Lines 27590 27579 -11
===============================================
- Hits 17418 17414 -4
+ Misses 8557 8553 -4
+ Partials 1615 1612 -3 |
qdm12
force-pushed
the
qdm12/blockstate/getruntime
branch
from
3bde739 to
6779a19
Compare
qdm12
requested review from
noot,
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj and
kishansagathiya
as code owners
qdm12
force-pushed
the
qdm12/blockstate/getruntime
branch
from
6779a19 to
f28b105
Compare
qdm12
force-pushed
the
qdm12/blockstate/getruntime
branch
from
f28b105 to
2612f74
Compare
|
This will need to be rebased after #2781 is merged |
qdm12
force-pushed
the
qdm12/blockstate/getruntime
branch
3 times, most recently
from
cca936b to
537fc8b
Compare
EclesioMeloJunior
approved these changes
Nov 8, 2022
qdm12
force-pushed
the
qdm12/blockstate/getruntime
branch
from
537fc8b to
c709f81
Compare
- Less implicit behavior using the best block hash if nil - Allows to track more easily what's plugged in
- Rename to `bestBlockHash` to have apparent search results
qdm12
force-pushed
the
qdm12/blockstate/getruntime
branch
from
c709f81 to
e1a0205
Compare
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The aim was to better see the use of the blockstate
GetRuntimemethod.There is no hurry to merge this, but it could be a nice addition imo.
Tests
Issues
Primary Reviewer
@EclesioMeloJunior