Allow for non-SPZ encoded vertex attributes #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @lilleyse |
weegeekps
approved these changes
Jun 30, 2025
There was a problem hiding this comment.
@Ronald909, sorry about the delay in looking at this. I think this is a good change and I will merge, but with the extension split that I am working on right now, this language may change.
I'm going to open a PR for the split and I will cc you so you can take a look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@weegeekps This PR is a proposal to allow for uncompressed attributes outside of the SPZ compressed payload. This change is needed to support Gaussian Splats feature attribution where additional vertex attribute(s) (i.e. FEATURE_INDEX_i ) are required but are not supported in the SPZ format.