Skip to content

version check from PR #156 doesn't cover latest v8 #161

@hpmachining

Description

@hpmachining

This pull request doesn't cover the latest (major version 13) v8 because the minor version isn't > 6.

Changing if V8_MAJOR_VERSION < 10 || (V8_MAJOR_VERSION >= 12 && V8_MINOR_VERSION > 6)
to if V8_MAJOR_VERSION < 10 || (V8_MAJOR_VERSION >= 12 && V8_MINOR_VERSION > 6) || (V8_MAJOR_VERSION >= 13)
works, but seems like there should be more concise way.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions