This repository was archived by the owner on Mar 15, 2021. It is now read-only.
Fix build #61
Open
Fix build #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a bool function that doesn't return. Since it's not used anyway, we can make it void.
|
I've made the same fix locally for cmake. I think it's good. One missing change would be how to set the libdir as appropriate. About the change from bool to void, this looks a very different thing. Would you mind to send a separate PR for this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the build on my system where it was requiring me to define
LIBOBS_INCLUDE_DIRinstead of just find the right LibObsConfig.cmake file.