-
Notifications
You must be signed in to change notification settings - Fork 316
Release v2.8.0 #1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release v2.8.0 #1048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added better image compression - added tests
Version name and version code update for v2.7.5
https://jira.catrob.at/browse/PAINTROID-352?jql=project%20%3D%20PAINTROID added layout_marginRight of 10dp to the pocketpaint_stroke_width_seek_bar. BEFORE # AFTER  ### Your checklist for this pull request Please review the [contributing guidelines](https://github.com/Catrobat/Paintroid/blob/develop/README.md) and [wiki pages](https://github.com/Catrobat/Catroid/wiki/) of this repository. - [x] Include the name of the Jira ticket in the PR’s title - [x] Include a summary of the changes plus the relevant context - [x] Choose the proper base branch (*develop*) - [x] Confirm that the changes follow the project’s coding guidelines - [x] Verify that the changes generate no compiler or linter warnings - [x] Perform a self-review of the changes - [x] Verify to commit no other files than the intentionally changed ones - [ ] Include reasonable and readable tests verifying the added or changed behaviour - [x] Confirm that new and existing unit tests pass locally - [ ] Check that the commits’ message style matches the [project’s guideline](https://github.com/Catrobat/Catroid/wiki/Commit-Message-Guidelines) - [x] Stick to the project’s gitflow workflow - [x] Verify that your changes do not have any conflicts with the base branch - [ ] After the PR, verify that all CI checks have passed - [ ] Post a message in the *#paintroid* [Slack channel](https://catrobat.slack.com) and ask for a code reviewer
-Based on the brush tool -Adds an MaskFilter to the paint which immitates watercolor. -Also shows the color in the colorpreview on the bottom right. Added an AlphaSlider in Colorpicker: -Instead of only appearing in the HsvColorpicker the slider now appears also in PreSelectorview. It does not appear in the RGBview. -When the app is opened from catroid the slider disappears. -The Slider controls the alpha value of the color. However when the watercolor tool is selected the Slider controls the strength of the blureffect. Added watercolor icon. Added Tests; -New tests for watercolortool -Additional tests for colorpickerintegration -fixed other tests for the new implementation. Bugs: (visual) -For a new ticket, when the watercolor tool is selected and you change the alpha slider in the colorpicker, you get a new color with a lower alpha value. When you now change to another tool with a previewcolor (e.g. Brush). The alpha value of the preview color will be the 255(maximum) and in the colorpicker the value will still be the old value.
removing coroutines which save and load the image, resulting in freeze.
removing coroutines which save and load the image, resulting in freeze.
New Crowdin translations by Github Action
New Colorpicker Crowdin translations by Github Action
most of implementation should work now, still have to test everything and write tests.
PAINTROID-305: Adding a connected segment with line tool
updated androidCompileSdkVersion and androidTargetSdkVersion from 29 to 30
PAINTROID-324 When you load an image and select colour pipette app hangs for a while
PAINTROID-149 Better png compression (Research and implementation)
PAINTROID-357 [🔺URGENT🔺] androidTargetSdkVersion = 30
PAINTROID-290: Implemented watercolor brush with changes to colorpicker
PAINTROID-350 Color of bottom bar icons is wrong in landscape mode
Alpha value is set correctly, also when switching between watercolor and other tools
…ot_Changed Paintroid-366 Alpha value on the third tab of color picker is ignored
… Google Play Store and Marketing
PAINTROID-365 Fastlane Screengrab Setup
…_fixes PAINTROID-365 Fixing Screengrabfile
New Crowdin translations by Github Action
New Colorpicker Crowdin translations by Github Action
…licking outside of the view (onCancel)
ContentLoadingProgressBar is only shown, if action takes longer than 500ms, prevents screen from flashing
PAINTROID-361 Colorpicker permanently sends color to catroid
…shing_when_saving_image PAINTROID-142: No flashing/blinking of the screen when saving or copying images
…yInteractor, MenuFileActivityIntegrationTest, OraFileFormatIntegrationTest
…r in MainActivityIntegrationTest
…iling tests in PAINTROID-300
PAINTROID-300, 299, 329
"+" didn't not appear when line was drawn in one swipe * setting startpoint plus endpoint and drawing a line was handled differently * drawing a line in one swipe behaves now like setting startpoint and endpoint separately * also fixes that line couldn't be extended with swiping after clicking "+" (PAINTROID-383) * when drawing a new line (without clicking on "+" before) the old line vanishes immediately * new lines drawn while swiping are appended to previous drawn lines
…s_not_appearing PAINTROID-382: "+" icon not appearing in line tool after drawing the first line segment
display variable could be null, null check added as display.getSize is deprecated with API level 30, added alternative for newer versions
Fixing Paintroid build with Catroid
…nter_ZoomableImageView PAINTROID-369: Crash NullPointerException: colorpicker.ZoomableImageView
PAINTROID-371 IndexOutOfBoundsException paintroid.model.LayerModel.getLayerAt and similar crashes with layers (#3 in Crashes and ANRs)
New Crowdin translations by Github Action
New Colorpicker Crowdin translations by Github Action
New Crowdin translations by Github Action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.