Skip to content

Conversation

wslany
Copy link
Member

@wslany wslany commented Mar 17, 2022

No description provided.

illo1311 and others added 30 commits September 27, 2021 16:36
- added better image compression
- added tests
Version name and version code update for v2.7.5
https://jira.catrob.at/browse/PAINTROID-352?jql=project%20%3D%20PAINTROID

added layout_marginRight of 10dp to the pocketpaint_stroke_width_seek_bar.

BEFORE
#![Before](https://user-images.githubusercontent.com/81173749/134683014-7d7e5587-92ed-40be-99df-7fa357a2449f.jpg)

AFTER
![After](https://user-images.githubusercontent.com/81173749/134683048-077b2fc1-cc8a-40d9-b257-926293238009.jpg)


### Your checklist for this pull request
Please review the [contributing guidelines](https://github.com/Catrobat/Paintroid/blob/develop/README.md) and [wiki pages](https://github.com/Catrobat/Catroid/wiki/) of this repository.

- [x] Include the name of the Jira ticket in the PR’s title
- [x] Include a summary of the changes plus the relevant context
- [x] Choose the proper base branch (*develop*)
- [x] Confirm that the changes follow the project’s coding guidelines
- [x] Verify that the changes generate no compiler or linter warnings
- [x] Perform a self-review of the changes
- [x] Verify to commit no other files than the intentionally changed ones
- [ ] Include reasonable and readable tests verifying the added or changed behaviour
- [x] Confirm that new and existing unit tests pass locally
- [ ] Check that the commits’ message style matches the [project’s guideline](https://github.com/Catrobat/Catroid/wiki/Commit-Message-Guidelines)
- [x] Stick to the project’s gitflow workflow
- [x] Verify that your changes do not have any conflicts with the base branch
- [ ] After the PR, verify that all CI checks have passed
- [ ] Post a message in the *#paintroid* [Slack channel](https://catrobat.slack.com) and ask for a code reviewer
-Based on the brush tool
-Adds an MaskFilter to the paint which immitates watercolor.
-Also shows the color in the colorpreview on the bottom right.

Added an AlphaSlider in Colorpicker:
-Instead of only appearing in the HsvColorpicker the slider now appears also in
PreSelectorview. It does not appear in the RGBview.
-When the app is opened from catroid the slider disappears.
-The Slider controls the alpha value of the color. However when the watercolor tool is selected the Slider controls
the strength of the blureffect.

Added watercolor icon.

Added Tests;
-New tests for watercolortool
-Additional tests for colorpickerintegration
-fixed other tests for the new implementation.

Bugs:
(visual)
-For a new ticket, when the watercolor tool is selected and you change the alpha slider in the
colorpicker, you get a new color with a lower alpha value. When you now change to another tool
with a previewcolor (e.g. Brush). The alpha value of the preview color will be the 255(maximum) and
in the colorpicker the value will still be the old value.
removing coroutines which save and load the image, resulting in freeze.
removing coroutines which save and load the image, resulting in freeze.
New Crowdin translations by Github Action
New Colorpicker Crowdin translations by Github Action
most of implementation should work now, still have to test everything and write tests.
PAINTROID-305: Adding a connected segment with line tool
updated androidCompileSdkVersion and androidTargetSdkVersion from 29 to 30
PAINTROID-324 When you load an image and select colour pipette app hangs for a while
PAINTROID-149 Better png compression (Research and implementation)
PAINTROID-357 [🔺URGENT🔺] androidTargetSdkVersion = 30
PAINTROID-290: Implemented watercolor brush with changes to colorpicker
PAINTROID-350 Color of bottom bar icons is wrong in landscape mode
Alpha value is set correctly, also when switching between watercolor and other tools
…ot_Changed

Paintroid-366 Alpha value on the third tab of color picker is ignored
PAINTROID-365 Fastlane Screengrab Setup
…_fixes

PAINTROID-365 Fixing Screengrabfile
New Crowdin translations by Github Action
New Colorpicker Crowdin translations by Github Action
barcodepony and others added 25 commits January 2, 2022 22:07
ContentLoadingProgressBar is only shown, if action takes longer than 500ms, prevents screen from flashing
PAINTROID-361 Colorpicker permanently sends color to catroid
…shing_when_saving_image

PAINTROID-142: No flashing/blinking of the screen when saving or copying images
…yInteractor, MenuFileActivityIntegrationTest, OraFileFormatIntegrationTest
"+" didn't not appear when line was drawn in one swipe

* setting startpoint plus endpoint and drawing a line was handled differently

* drawing a line in one swipe behaves now like setting startpoint and endpoint separately

* also fixes that line couldn't be extended with swiping after clicking "+" (PAINTROID-383)

* when drawing a new line (without clicking on "+" before)
  the old line vanishes immediately

* new lines drawn while swiping are appended to previous drawn lines
…s_not_appearing

PAINTROID-382: "+" icon not appearing in line tool after drawing the first line segment
display variable could be null,
null check added

as display.getSize is deprecated with API level 30, added alternative for newer versions
…nter_ZoomableImageView

PAINTROID-369: Crash NullPointerException: colorpicker.ZoomableImageView
PAINTROID-371 IndexOutOfBoundsException paintroid.model.LayerModel.getLayerAt and similar crashes with layers (#3 in Crashes and ANRs)
New Crowdin translations by Github Action
New Colorpicker Crowdin translations by Github Action
New Crowdin translations by Github Action
@wslany wslany merged commit ca8ba23 into master Mar 17, 2022
@wslany wslany deleted the release-v2.8.0 branch March 17, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.