- 
                Notifications
    
You must be signed in to change notification settings  - Fork 6
 
Adjust command used to run some services as we're using yarn workspaces now #782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust command used to run some services as we're using yarn workspaces now #782
Conversation
| 
           Changes release to Replicated on channel feature_sc_496033_migrate_storage_to_yarn_workspace! Check the Replicated Dashboard for more details.  | 
    
          Summary of ChangesHello @moicalcob, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adjusts the service execution commands and file paths in  Highlights
 Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either  
 Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a  Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the startup commands for several services to align with a new directory structure resulting from the adoption of yarn workspaces. The changes are mostly correct, replacing generic app paths with workspace-specific paths and switching from absolute to relative paths. However, I've identified a critical inconsistency in one of the service configurations that was likely missed and would cause it to fail. My review includes a specific comment and suggestion to fix this.
| 
           Changes release to Replicated on channel feature_sc_496033_migrate_storage_to_yarn_workspace! Check the Replicated Dashboard for more details.  | 
    
…feature/sc-496033/migrate-storage-to-yarn-workspace
| 
           Changes release to Replicated on channel feature_sc_496033_migrate_storage_to_yarn_workspace! Check the Replicated Dashboard for more details.  | 
    
| 
           Changes release to Replicated on channel feature_sc_496033_migrate_storage_to_yarn_workspace! Check the Replicated Dashboard for more details.  | 
    
| 
           Changes release to Replicated on channel feature_sc_496033_migrate_storage_to_yarn_workspace! Check the Replicated Dashboard for more details.  | 
    
No description provided.