Skip to content

Conversation

@moicalcob
Copy link
Contributor

No description provided.

@moicalcob moicalcob self-assigned this Oct 24, 2025
@moicalcob moicalcob added the release-changes Deploy changes in a Replicated channel label Oct 24, 2025
@github-actions
Copy link

Changes release to Replicated on channel feature_sc_496033_migrate_storage_to_yarn_workspace! Check the Replicated Dashboard for more details.
If you need to test the changes, you can assign the channel to your customer and download the latest version from the Admin Console.

@gemini-code-assist
Copy link

Summary of Changes

Hello @moicalcob, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adjusts the service execution commands and file paths in values.yaml to accommodate the adoption of Yarn Workspaces. The changes ensure that services such as importApi, importWorker, ldsApi, mapsApi, sqlWorker, workspaceApi, and workspaceSubscriber are correctly executed with the updated directory structure.

Highlights

  • Yarn Workspaces Adjustment: The primary change involves adjusting the commands used to run services to align with the adoption of Yarn Workspaces. This ensures that the correct paths are used for executing scripts and accessing necessary files within the new workspace structure.
  • Path Updates in values.yaml: Several paths within the values.yaml file have been updated to reflect the new directory structure under Yarn Workspaces. This includes changes to the locations of ready-to-run.js, index.js, and subscriber/index.js for various services like importApi, importWorker, ldsApi, mapsApi, sqlWorker, workspaceApi, and workspaceSubscriber.
  • Service Argument Modifications: The arguments for running several services have been modified to use the correct paths for the distribution files. This ensures that the services can locate and execute the necessary scripts within the Yarn Workspaces environment.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the startup commands for several services to align with a new directory structure resulting from the adoption of yarn workspaces. The changes are mostly correct, replacing generic app paths with workspace-specific paths and switching from absolute to relative paths. However, I've identified a critical inconsistency in one of the service configurations that was likely missed and would cause it to fail. My review includes a specific comment and suggestion to fix this.

@github-actions
Copy link

Changes release to Replicated on channel feature_sc_496033_migrate_storage_to_yarn_workspace! Check the Replicated Dashboard for more details.
If you need to test the changes, you can assign the channel to your customer and download the latest version from the Admin Console.

…feature/sc-496033/migrate-storage-to-yarn-workspace
@github-actions
Copy link

Changes release to Replicated on channel feature_sc_496033_migrate_storage_to_yarn_workspace! Check the Replicated Dashboard for more details.
If you need to test the changes, you can assign the channel to your customer and download the latest version from the Admin Console.

@github-actions
Copy link

Changes release to Replicated on channel feature_sc_496033_migrate_storage_to_yarn_workspace! Check the Replicated Dashboard for more details.
If you need to test the changes, you can assign the channel to your customer and download the latest version from the Admin Console.

@github-actions
Copy link

Changes release to Replicated on channel feature_sc_496033_migrate_storage_to_yarn_workspace! Check the Replicated Dashboard for more details.
If you need to test the changes, you can assign the channel to your customer and download the latest version from the Admin Console.

@moicalcob moicalcob merged commit 987418c into main Oct 31, 2025
4 checks passed
@moicalcob moicalcob deleted the feature/sc-496033/migrate-storage-to-yarn-workspace branch October 31, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-changes Deploy changes in a Replicated channel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants