Skip to content

fix(trainer): init self.generate_sweep_kwarg at self.__init__ #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2023
Merged

fix(trainer): init self.generate_sweep_kwarg at self.__init__ #460

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66fb10c
fix(trainer): init self.generate_sweep_kwarg at self.__init__
mymusise Apr 28, 2023
7ef5d2c
same with nth_evaluation
mymusise Apr 28, 2023
76d841e
add `setup_generate_sweep_kwarg` method that initializes generate_swe…
mymusise Apr 28, 2023
05d39ca
drop setup_generate_sweep_kwarg
mymusise Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions trlx/trainer/accelerate_base_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,16 @@ def __init__(self, config, **kwargs): # noqa: C901
"Set `tracker` to `None` to disable tracking."
)

self.nth_evaluation = 0
self.generate_sweep_kwarg = None
for k, v in self.config.method.gen_kwargs.items():
if isinstance(v, list):
if self.generate_sweep_kwarg is not None:
logger.info("Only a single sweep is allowed, {k} is going to be set to {v[0]}")
self.generate_kwargs[k] = v[0]
else:
self.generate_sweep_kwarg = (k, v)

def setup_model(self):
"""
Returns a model derived from an instance's TRLConfig
Expand Down Expand Up @@ -478,15 +488,6 @@ def learn(self): # noqa: C901
"""
logger.info("Starting training")

self.generate_sweep_kwarg = None
for k, v in self.config.method.gen_kwargs.items():
if isinstance(v, list):
if self.generate_sweep_kwarg is not None:
logger.info("Only a single sweep is allowed, {k} is going to be set to {v[0]}")
self.generate_kwargs[k] = v[0]
else:
self.generate_sweep_kwarg = (k, v)

self.prepare_learning()
self.iter_count = 0
self.nth_evaluation = 0
Expand Down