Skip to content

Conversation

jon-tow
Copy link
Collaborator

@jon-tow jon-tow commented Apr 5, 2023

Use the pinned dependencies in requirements.txt for unit testing in CI re discussion in the recent trlx meeting.

@jon-tow jon-tow requested a review from maxreciprocate April 5, 2023 18:29
Copy link
Collaborator

@maxreciprocate maxreciprocate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jon! I've checked dependencies used on CI to be the same as in requirements, and since the build passes that means it's all good!

run: |
python -m pip install --upgrade pip
pip install -e ".[dev,bnb]"
pip install torch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would get later overwritten by

torch==2.0.0+cu117

from requirements.txt

Build log:

Collecting torch==2.0.0+cu117
  Downloading https://download.pytorch.org/whl/cu117/torch-2.0.0%2Bcu117-cp38-cp38-linux_x86_64.whl (1843.9 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.8/1.8 GB 699.2 kB/s eta 0:00:00

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh huh. Running pip install -r requirements.txt locally I get:

ERROR: Could not find a version that satisfies the requirement torch==2.0.0+cu117 (from versions: 1.11.0, 1.12.0, 1.12.1, 1.13.0, 1.13.1, 2.0.0)
ERROR: No matching distribution found for torch==2.0.0+cu117

I guess the CI hosts have CUDA/GPU support? I'll remove the lone pip install torch!

@jon-tow
Copy link
Collaborator Author

jon-tow commented Apr 5, 2023

Thanks for the review Max!

@jon-tow jon-tow merged commit 9fd1f0a into CarperAI:main Apr 5, 2023
@jon-tow jon-tow deleted the pin-deps-ci branch April 5, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants