Skip to content

read tokenizer path from config correctly #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2023
Merged

read tokenizer path from config correctly #230

merged 1 commit into from
Jan 27, 2023

Conversation

JustinAWei
Copy link
Contributor

In the specific config referenced by summarize_rlhf, it seems like the model: block does not have tokenizer_path. There does seem to be one in tokenizer: however.

@LouisCastricato
Copy link
Contributor

@PhungVanDuy

jon-tow
jon-tow approved these changes Jan 27, 2023
View reviewed changes
Copy link
Collaborator

@jon-tow jon-tow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This was a recent-ish update and was never reflected in the example

@jon-tow jon-tow merged commit 005db47 into CarperAI:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jon-tow jon-tow jon-tow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JustinAWei @LouisCastricato @jon-tow