Support nested updates in merge
#219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `TRLConfig.update` will fail if given something like `{ "optimizer": { "name": "adam_8bit_bnb" } }" since it'll check if the `optimizer` key is in `updates`, but `merge` won't add it because the only keys updated are nested. Actually currently `merge` will check the values in updates in every nested dict, which is problematic when changing an attr that is common across many subconfigs (e.g `"name"`), so this way allows proper nested updates.
jon-tow
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
@cat-state nice catch 🙏 can repro here https://colab.research.google.com/drive/1RBLvwxh8KQlCjjo1QtkLMXMu4GfxcZoX?usp=sharing
thanks for the repro and test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
TRLConfig.updatewill fail if given something like{ "optimizer": { "name": "adam_8bit_bnb" } }"since it'll check if theoptimizerkey is inupdates, butmergewon't add it because the only keys updated are nested.mergewill check the keys to in every nested dict with the root level keys of the update config, which is problematic when changing an attr that is common across many subconfigs (e.g"name"), so this way allows proper nested updates.