Skip to content

Make Trainer.save_pretrained sub-directory optional #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2023
Merged

Make Trainer.save_pretrained sub-directory optional #201

merged 1 commit into from
Jan 17, 2023

Conversation

jon-tow
Copy link
Collaborator

@jon-tow jon-tow commented Jan 17, 2023 •
edited
Loading

  • Makes the Trainer.save_pretrained /hf_model sub-directory optional. Previously, if a directory was supplied to save_pretrained the hf_model name path would be hard joined as {directory}/hf_model. Now users can directly write to the path defined by directory instead.
    • Maybe the HF checkpoint dir should be an extra config? (Not sure if it's worth it).
  • Corrects the repo README.md to properly document save_pretrained usage.

maxreciprocate
maxreciprocate approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@maxreciprocate maxreciprocate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maxreciprocate maxreciprocate merged commit 7f4bafe into main Jan 17, 2023
@jon-tow jon-tow deleted the update-save-pretrained branch January 17, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxreciprocate maxreciprocate maxreciprocate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jon-tow @maxreciprocate