Skip to content

Update reward_fn signatures in examples #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 14, 2023
Merged

Update reward_fn signatures in examples #190

merged 2 commits into from
Jan 14, 2023

Conversation

jon-tow
Copy link
Collaborator

@jon-tow jon-tow commented Jan 13, 2023

  • Updates all examples with recent changes to expected reward_fn signature.
  • Updates the RLHF example accelerate config to point to the correct deepspeed_config_file when running from the summarize_rlhf dir (as suggested in the README). Otherwise, it leads FileNotFoundError: [Errno 2] No such file or directory: 'ds_config_trlx_gptj_summarize.json'

@jon-tow
Copy link
Collaborator Author

jon-tow commented Jan 13, 2023

@LouisCastricato before merging let me update the readme

@LouisCastricato
Copy link
Contributor

lol no

@jon-tow
Copy link
Collaborator Author

jon-tow commented Jan 13, 2023

@LouisCastricato
merge_Goose_Game_Honk copy

@jon-tow jon-tow merged commit 02bbfca into CarperAI:main Jan 14, 2023
@jon-tow jon-tow deleted the update-rlhf-example branch January 14, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxreciprocate maxreciprocate Awaiting requested review from maxreciprocate

1 more reviewer

@LouisCastricato LouisCastricato LouisCastricato approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jon-tow @LouisCastricato